please use CFLAGS CXXFLAGS CPPFLAGS and LDFLAGS

[GoogleCodeExporter]

please use CFLAGS CXXFLAGS CPPFLAGS and LDFLAGS

[GoogleCodeExporter]

This seems reasonable to me, and I'll be happy to commit it. For that matter, 
maybe we should be using a makefile (or *something* other than a shell 
script...)

Thanks for the patch.

Original comment by [email protected] on 11 Feb 2015 at 7:40

[GoogleCodeExporter]

BTW with around 20 cmake lines you can have everything working correctly.

that kind of build scripts are really painful for every kind of usage.

you are using -m64, this is wrong to me, do you want to exclude everybody using 
a non64 arch?

Original comment by [email protected] on 11 Feb 2015 at 7:55

[GoogleCodeExporter]

This is committed, along with some other minor tweaks (warning messages and the 
SONAME bits you asked for in issue 29) in r194.

Regarding your comment in #2: CLD's primary consumer is the Chromium 
open-source project, which doesn't use these scripts at all - it has a 
completely custom build system (GYP/GN and ninja) that have their own "unique" 
mechanisms for setting the various flags and options. The shell scripts are 
really just for hand-running tests and tweaking the build, it's kind of 
expected that an embedder would have their own tech for building that they'd 
want to pull this into.

I'm happy to take submissions for more robust (and simple) build logic! If 
you're willing to write it up, send it along and if it looks reasonable we'll 
get it committed and credit you in the commit message.

Original comment by [email protected] on 12 Feb 2015 at 11:26

• Changed state: Fixed