Comments (13)
thanks
Original comment by [email protected]
on 10 Feb 2015 at 3:37
from cld2.
This is committed, along with some other minor tweaks (warning messages and the
CFLAGS bits you asked for in issue 28) in r194.
I gave the libraries identical names to the files that the build system creates:
libcld2_dynamic.so
libcld2_full.so
libcld2.so
Original comment by [email protected]
on 12 Feb 2015 at 11:27
- Changed state: Fixed
from cld2.
nope, you should give something like 0.0.0
something like this :)
gcc -shared -Wl,-soname,libmystuff.so.1 \
-o libmystuff.so.1.0.1 a.o b.o -lc
(cmake handles it automatically, I'm trying to port the build script right now)
BTW not only chromium is using it, now also poedit!
thanks for the fixes so far!
Original comment by [email protected]
on 12 Feb 2015 at 11:38
from cld2.
So, CLD2 doesn't have release versions like this. The closest that we have is
the date of the data files, generally speaking. We could add a ".1" to make
things happy, but that's really about the only sensible thing at the moment
without actually having a "x.y.z." versioning scheme, which the project
currently lacks.
I didn't mean to imply with my comments in issue #28 that *only* Chromium uses
CLD; it's certainly not intended to be just for Chromium. The metapoint is that
most of the projects that incorporate CLD that I'm currently aware of compile
it at the same time as everything else, meaning they don't end up with a
standalone CLD library to link at runtime. It's a totally valid use case,
though, which is why I'm happy to take a makefile improvement :)
I'd like Dick's thoughts on versioning before committing to make it a ".1",
because we're likely stuck with whatever we do there for the forseeable future.
I'd hate to cause pain for the consumers of the library by mangling the version.
Original comment by [email protected]
on 12 Feb 2015 at 12:12
- Changed state: Accepted
from cld2.
Ok, I fixed some issues, and created the cmake file.
It wasn't trivial, since your build scripts are *far* from ideal.
Now the cmake is *exactly* as the build scripts, just I avoided inclusion of
headers files, since when you build the corresponding cc file the correspondant
header is already included in the #include directive.
Now of course it is working, just with a *FULL* explanation about your system,
I'll be glad to reduce it a lot, by using the created libraries for testing,
instead of rebuilding everything again from scratch.
this will simplify a lot the CMake file.
Original comment by [email protected]
on 12 Feb 2015 at 4:27
Attachments:
from cld2.
oops, I did a typo
to build you can just
mkdir build
cd build
cmake ..
make -j whatever
of course we can add flags to build only parts of the cld2, like
-DENABLE_TESTS=ON or something like this.
tests still need to be run manually (I don't know how to handle pipes with
cmake)
Original comment by [email protected]
on 12 Feb 2015 at 4:33
Attachments:
from cld2.
ping :-)
what about providing a soname just if some cmake flag is enabled?
Original comment by [email protected]
on 3 Mar 2015 at 6:54
from cld2.
changing SHARED to STATIC in CmakeLists.txt makes cmake build static libraries
Original comment by [email protected]
on 4 Mar 2015 at 4:37
from cld2.
Ping again, can you please just provide a SONAME like the svn revision? 1.0.194
for svn revision 194 for example.
You can change it at each commit, so everyone is happy (and I can create some
cmake stuff to automatically add it)
let me know, thanks
(this is a showstopper for Debian packaging)
Original comment by [email protected]
on 26 Mar 2015 at 4:41
from cld2.
Adding a new cmake file version, building faster (I link libraries rather than
rebuilding the all files each time for the testsuite) and adding a SONAME like
0.0.194 where 194 is the svn revision
Original comment by [email protected]
on 30 Mar 2015 at 2:45
Attachments:
from cld2.
Thanks for the cmake file. It's possible to actually build this project now.
Original comment by [email protected]
on 29 May 2015 at 2:22
from cld2.
Jason, can you take a look at what it would take to add this in? I don't have
any experience with CMake but it sounds like it's useful.
Original comment by [email protected]
on 29 May 2015 at 2:49
from cld2.
Actually this is part of Debian already, but I changed the cmake to use only
once the svn version
https://sources.debian.net/src/cld2/0.0.0~svn194-1/CMakeLists.txt/
Original comment by [email protected]
on 29 May 2015 at 4:16
from cld2.
Related Issues (20)
- CLD2 result chunk vector omits portions of input file HOT 6
- Dynamic data loading should not use iostream HOT 5
- Windows build fails: undeclared identifier 'close' HOT 6
- Support mmap-ing dynamic data on win32 HOT 5
- Build warning on Windows with clang HOT 2
- Eliminate redundancy and/or simplify default case for compiling unittest_data.h HOT 4
- Missing include in cld2_dynamic_data_loader.cc HOT 1
- cld2_dynamic_data.cc and cld2_dynamic_data_loader.cc problems on Win32 HOT 10
- Enable dynamic data for 20141015 release HOT 1
- New GCC 5.0 hits problem with narrowing in list-initializers HOT 2
- CLD should check result of "new" in all use cases HOT 1
- please use CFLAGS CXXFLAGS CPPFLAGS and LDFLAGS HOT 3
- cld2 testsuite failures HOT 3
- Compilation issues in Visual Studio
- Compilation failure on VS2015 on Windows
- Check in tools for generating generated_* files HOT 2
- Add armv8-a support HOT 5
- new code location? HOT 6
- Add possibility to set MinReliableKeepPercent HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cld2.