Points simply not being displayed

[jbehley]

Points simply not being displayed

[jbehley]

Hi @jingyibo123,

I finally investigated the bug and the checkbox was actually not working. I think I broke the code at some point in time.

I fixed the issue and now the checkbox should have an effect. (You can see the effect also by reloading the scan or by changing the tile.)

For convenience, I just added also an option to the settings.cfg: add car points: true, which activates the option at startup and therefore you don't have to activate it all the time.

Does this finally resolve your problem?

[jbehley]

For the KITTI dataset, we removed for each scan the points on the car. And this is a fixed size bounding box.

It might be that you have to turn off this by activating "add car points" under the visual options. If you then change the tile it should now show all points.

[jingyibo123]

Thanks for the super fast response!
It makes a lot sense judging from the shape and the orientation !

However checking "add car points" and changing the tile doesnot recover the missing points, not even checking the box and reopening the dataset.

After completely disabling the logic in src/shaders/fill_tile_points.vert, the points are actually recovered..
I'll dig into why the checkbox is not working..

Thanks again for your help!
Wish you a great day.

[jbehley]

I will have a look, since the checkbox should have an effect.

the point removal is happening in a shader:

point_labeler/src/shaders/fill_tile_points.vert

Line 40 in 769c060

bool is_car_point = (in_vertex.x < 3.0 && in_vertex.x > -2.0 && abs(in_vertex.y) < 2.0);

you can remove the line. I will later see what does not work there.

[jingyibo123]

Thanks so much @jbehley, that totally solved the problem!
I'll close the issue.