jbub/banking

Banking library written in Go.

banking's Issues

calculateMod returns incorrect result on 32 bit platforms (like wasm)

64 bit values need to be int64 to run properly on 32 bit platforms, which do still exist :-)

Pull request coming.

Test case:

package main

import "github.com/jbub/banking/iban"

func main() {
	_, err := iban.New("AL50134113214854624345996786")
	if err != nil {
		println(err.Error())
	}
}

Here's one way to run it as a 32 bit program from anywhere (assuming you have tinygo installed); there may be other ways.

tinygo run -target wasi main.go

Expected output: nothing.
When bug present, prints an error.

From tinygo-org/tinygo#2642

Support more iban types

• East Timor
• Faroe Islands
• Greenland
• Iraq
• Kosovo
• North Macedonia
• Palestinian territories
• Saint Lucia
• Seychelles
• Ukraine

Hard to use for redaction

The Validate() function doesn't return a length, so it is hard to use to redact the leading IBAN portion of a string.

Typo in validation response: "invalid bban length"

I suspect this should be "invalid iban length", not "invalid bban length":

banking/iban/iban.go

Line 18 in 801c770

ErrInvalidBbanLength = errors.New("iban: invalid bban length")