Giter Site home page Giter Site logo

code_owners's Issues

Gem does not support global ownership

If CODEOWNER file is something like

*                  @global-owner
/path/to/file      @specific-owner

/path/to/file will always be owned by @global-owner instead of @specific-owner

No such file or directory exception

Issue

When the CODEOWNERS file it's on another valid path (i.e. the root or docs/) the utility throws an "no such file or directory" exception.

Obviously if the file doesn't exist it'll show the same exception

Suggestion

It should search on all possible routes and... if the file doesn't exist... exit and notify the user in a more gracefully way.

Backtrace:

Edgars-MacBook-Pro:jekyll-theme-marketing cetinajero$ code_owners 
/Users/cetinajero/.rvm/gems/ruby-2.4.1/gems/code_owners-1.0.4/lib/code_owners.rb:31:in `read': No such file or directory @ rb_sysopen - /Users/cetinajero/projects/jekyll/jekyll-theme-marketing/.github/CODEOWNERS (Errno::ENOENT)
	from /Users/cetinajero/.rvm/gems/ruby-2.4.1/gems/code_owners-1.0.4/lib/code_owners.rb:31:in `pattern_owners'
	from /Users/cetinajero/.rvm/gems/ruby-2.4.1/gems/code_owners-1.0.4/lib/code_owners.rb:17:in `ownerships'
	from /Users/cetinajero/.rvm/gems/ruby-2.4.1/gems/code_owners-1.0.4/bin/code_owners:6:in `<top (required)>'
	from /Users/cetinajero/.rvm/gems/ruby-2.4.1/bin/code_owners:23:in `load'
	from /Users/cetinajero/.rvm/gems/ruby-2.4.1/bin/code_owners:23:in `<main>'
	from /Users/cetinajero/.rvm/gems/ruby-2.4.1/bin/ruby_executable_hooks:15:in `eval'
	from /Users/cetinajero/.rvm/gems/ruby-2.4.1/bin/ruby_executable_hooks:15:in `<main>'

support CODEOWNERS.ignore

as a nice way of handling files that should not be owned
because otherwise we need to keep a list in the failing test + the cli always breaks

Add Dockerfile / publish image for self-contained execution

This adds another option for a way to install/run the tool that circumvents having to install the gem and thus fewer dependencies on the developer's system (i.e. for someone who wants to just use Docker vs. Docker and rvm/rbenv/asdf-vm/etc.)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.