jdeathe/centos-ssh-varnish

Varnish Cache - CentOS - Docker image build.

centos-ssh-varnish's Issues

Varnish 3.0 is unsupported.

Update to use Varnish 4.0 or 4.1 since 3.0 is now unsupported.

https://www.varnish-cache.org/releases

Add SCMI based install/uninstall methods

Add the necessary install/uninstall labels and template systemd unit-file necessary to work with the SCMI embedded installer.

Update httpd backend version in examples/tests to resolve session issues.

jdeathe/centos-ssh-apache-php:3.0.1 fixes the "Session info", allowing the session.name to be defined by the operator.

Push semantic tags of existing image tags to docker hub

Before releasing 1.3.2 the existing image tags need to be pushed with semantic version numbers.

Add varnishncsa access logs

Add option to enable access logging.

• https://varnish-cache.org/docs/6.0/reference/varnishncsa.html

Add environment variable: VARNISH_AUTOSTART_VARNISHNCSA.

Fix known issues with helper scripts.

• Errors are seen for cd command when running the run.sh or build.sh.
• Use local variable scope for BASH helper functions.
• Build script fails to display image if missing tag parameter.
• Errors seen during container removal steps of run.sh.
• Update SSH configuration path in Systemd definition file.

Add better test method for running parameters

The current method of testing the parameters set is very crude. The logs are scanned for the parameters set via the varnishd-wrapper script. This doesn't verify against the actual running configuration so a better method would be to query the settings using the varnishadm command varnsishadm param.show.

Incorrect URL to storage types in README

Should be:

• https://www.varnish-cache.org/docs/4.1/index.html
• https://www.varnish-cache.org/docs/4.1/reference/varnishd.html?highlight=storage%20types#storage-backend-options

Default to work with single boot2docker docker host (Kitematic)

Make the default work with the Kitematic boot2docker based VM that comes with Docker Tools. The Docker VM uses IP 192.168.99.100.

Add feature to run.conf and run.sh to use an alternative Docker host VM such as CoreOS in a 3 node cluster.

Bash local readonly variables declared incorrectly.

Several scripts use the syntax:

local readonly variable="value"

This is incorrect and should be replaced with:

local -r variable="value"

Specify the source tag instead of branch.

Latest tag is 1.4.0 which will also bring this container up to CentOS 6.7

Allow configuration to be defined as an environment variable.

Update source image to 1.8.1 release

• Update source image to jdeathe/centos-ssh:1.8.1
• Add a src directory for the image root files.
• Add STARTUP_TIME variable for the logs-delayed Makefile target.
• Add clearer, improved shpec test case output.
• Add a Docker healthcheck.

Update httpd backend version in examples/tests to resolve session issues.

Patch back #98 to centos-6 branch

Linked backend containers

Linked backend containers update /etc/hosts so should be able to avoid the requirement of using --add-host backend-1:DOCKER_HOST_IP

This would require a centos-ssh-varnish container on every Docker host but don't feel that's an issue.

Replace deprecated MAINTAINER with a LABEL.

Ref: https://docs.docker.com/engine/deprecated/

Deprecated In Release: v1.13.0
MAINTAINER was an early very limited form of LABEL which should be used instead.

Update upstream source to 1.8.2.

https://github.com/jdeathe/centos-ssh/releases/tag/1.8.2

SHPEC_ROOT not defined in Makefile

Missing SHPEC_ROOT := test/shpec from environment.mk

Update to Varnish 4.1.8

http://varnish-cache.org/releases/

Package sources have been relocated to Packagecloud.io

http://varnish-cache.org/releases/install_redhat.html#official-packages-of-4-1

https://packagecloud.io/varnishcache/varnish41/install#manual

Remove unsupported environment variables.

Support for the following was removed in release 1.3.0 however the environment variables where not removed from the Dockerfile.

• VARNISH_ADMIN_LISTEN_ADDRESS
• VARNISH_ADMIN_LISTEN_PORT
• VARNISH_LISTEN_ADDRESS
• VARNISH_LISTEN_PORT
• VARNISH_PIDFILE
• VARNISH_SECRET_FILE

https://github.com/jdeathe/centos-ssh-varnish/blob/1.3.0/Dockerfile#L56

Remove scmi source from repository

The scmi script is added to the image from the upstream source image jdeathe/centos-ssh

Having it in the repository means it needs to be maintained but is never added to this image from the Dockerfile build.

Review/update systemd install and definition scripts.

• Update to use etcd version 2.
• Should be using the "awk" based functions to detect configuration volumes.
• Make use of bash double square brace type syntax to reduce amount of escaped double quotes necessary.
• Use Environment variables to help simplify release maintenance.

Add centos-7 branch details to readme

Add correct link to Varnish 6.0 documentation

Add support for secrets

Although there's no sensitive values within the configuration file currently - consideration should be given to allowing operators to use Docker secrets/config to define the configuration file content via VARNISH_VCL_CONF.

Add generic ready state test function

Update varnish to varnish-4.1.7-1.el6

Currently the image uses varnish-4.1.5-1.el6

Update to the latest varnish-4.1.7-1.el6

SCMI service unit constants should be readonly

https://github.com/jdeathe/centos-ssh-varnish/blob/1.4.0/src/opt/scmi/service-unit.sh#L4-L25

Strip Proxy header

https://httpoxy.org/

Add PROXY support to the 8443 binding

Adding PROXY protocol (from HAProxy) should allow the correct client/server IP address to be populated when handling TLS terminated traffic on port 8443.

Ref:

• http://blog.haproxy.com/2012/06/05/preserve-source-ip-address-despite-reverse-proxies/
• https://www.varnish-cache.org/docs/4.1/reference/varnishd.html#options

Update source to centos-6-1.7.6 release tag

• Add source from jdeathe/centos-ssh:1.7.6
• Add reduced number of build steps to image which helps reduce final image size.
• Add a change log (CHANGELOG.md).
• Add support for semantic version numbered tags.
• Add minor code style changes to the Makefile.

Make a start with:

• Add functional tests using shpec.

HTTP and HTTPS cache should be separated

If the content changes between http and https protocols then the configuration needs to set the vcl_hash hash_data accordingly.

The PHP Hello, world! app requires this so it would make sense to enable it by default.

Update to Varnish 6.0

• https://varnish-cache.org/docs/5.2/whats-new/changes-5.0.html
• https://varnish-cache.org/docs/5.2/whats-new/changes-5.1.html
• https://varnish-cache.org/docs/5.2/whats-new/changes-5.2.html
• https://varnish-cache.org/docs/5.2/whats-new/upgrading-5.0.html
• https://varnish-cache.org/docs/5.2/whats-new/upgrading-5.1.html
• https://varnish-cache.org/docs/5.2/whats-new/upgrading-5.2.html
• https://packagecloud.io/varnishcache/varnish52

Add docker-compose example

Add a docker-compose configuration file to demonstrate usage with the jdeathe/centos-ssh-apache-php backend.

Add docker-compose example

Patch back #89 to centos-6 branch

Update for 1.2.0 release.

CentOS version has changed from 6.6 to 6.7.

Specify package versions to improve build reproducibility.

Update upstream source to 1.8.3

Update source image to 1.8.3 tag.

Systemd should make use of exec Limit for ulimit options

http://man7.org/linux/man-pages/man5/systemd.exec.5.html

Consider splitting out the backend configuration into a separate VCL file.

It's possible to include a VCL into the main configuration. Investigate splitting out the backend configuration.

• https://www.varnish-cache.org/docs/4.1/reference/vcl.html#include-statement
• https://www.varnish-cache.org/docs/4.1/reference/vcl.html#subroutines

Missing /etc/varnish/docker-cluster.vcl from container

Add the example cluster configuration to the Docker image to allow the VARNISH_VCL_CONF to be used to set either /etc/varnish/docker-default.vcl or /etc/varnish/docker-cluster.vcl

Expect scripts fail when "-f" is appended to shebang.

• https://github.com/jdeathe/centos-ssh-varnish/blob/1.3.2/test/telnet-proxy-tcp4.exp#L1

Error message:

/usr/bin/env: expect -f: No such file or directory

Update source image to 1.8.4

CVE-2017-12425

https://varnish-cache.org/security/VSV00001.html#vsv00001

Update Varnish to 4.1.10

https://github.com/varnishcache/varnish-cache/blob/4.1/doc/changes.rst#varnish-cache-4110-2018-04-25

Hostnames with underscores are invalid

Due to the way docker-compose sets names for services I changed the naming of the backend hosts to use the form httpd_1, httpd_2 etc instead of backend-1, backend-2 etc however this results in invalid hostname requests.

[Wed Jan 25 21:37:10.373213 2017] [core:debug] [pid 122] vhost.c(796): [client 172.172.1.7:33498] AH02415: [strict] Invalid host name 'httpd_1', problem near: _1
[Wed Jan 25 21:37:10.373467 2017] [core:debug] [pid 122] vhost.c(891): [client 172.172.1.7:33498] AH00550: Client sent malformed Host header: httpd_1
[Wed Jan 25 21:37:10.373478 2017] [core:debug] [pid 122] protocol.c(1385): [client 172.172.1.7:33498] AH00569: client sent HTTP/1.1 request without hostname (see RFC2616 section 14.23): /
[Wed Jan 25 21:37:10.373491 2017] [headers:debug] [pid 122] mod_headers.c(900): AH01503: headers: ap_headers_error_filter()

Update the run.sh helper script to make use of configuration volume.

The optional configuration volume is not used in the default run example but is necessary to allow config changes due to the complexity of the .vlc files in this container setup.

Note that the boot2docker host virtual machine only maps the users' home directory so when running docker commands via a docker host VM (proxy) the only directories that can be mapped from the host machine (The Mac) to the Docker host are those within the users' home directory.

Updated README for 1.2.0 release.

• Run examples should be using --privileged to allow the service to run correctly.
• SSH path needs updating in the volume configuration example.
• Need examples of using the Environment variables.

Update to varnish 4.1.5

Upgrade from varnish-4.1.3-1.el6 to varnish-4.1.5-1.el6.

Add a .dockerfileignore

https://docs.docker.com/engine/reference/builder/#dockerignore-file