jdevalk/clicky

WordPress plugin for Clicky.com Analytics

👋🏼️ Hi there

I’m Joost de Valk, an internet entrepreneur and developer from the Netherlands.

Read my bio on my personal site, where you can also reach me.

Currently working on AAA Option Optimizer, a new project that's still a secret, helping our portfolio companies and a few consulting projects.

clicky's Issues

Add short descriptions to classes/methods/properties/class constants

The following test functions are missing documentation describing what is being tested:

FILE: tests\admin-page-test.php                                               
----------------------------------------------------------------------        
FOUND 2 ERRORS AFFECTING 2 LINES                                              
----------------------------------------------------------------------        
 27 | ERROR | Missing short description in doc comment                        
 38 | ERROR | Missing short description in doc comment                        
----------------------------------------------------------------------        
                                                                              
                                                                              
FILE: tests\admin-test.php                                                    
----------------------------------------------------------------------        
FOUND 7 ERRORS AFFECTING 7 LINES                                              
----------------------------------------------------------------------        
  27 | ERROR | Missing short description in doc comment                       
  40 | ERROR | Missing short description in doc comment                       
  52 | ERROR | Missing short description in doc comment                       
  75 | ERROR | Missing short description in doc comment                       
 100 | ERROR | Missing short description in doc comment                       
 118 | ERROR | Missing short description in doc comment                       
 135 | ERROR | Missing short description in doc comment                       
----------------------------------------------------------------------        
                                                                              
                                                                              
FILE: tests\framework\unittestcase.php                                        
----------------------------------------------------------------------        
FOUND 1 ERROR AFFECTING 1 LINE                                                
----------------------------------------------------------------------        
 20 | ERROR | Missing short description in doc comment                        
----------------------------------------------------------------------        
                                                                              
                                                                              
FILE: tests\options-admin-test.php                                            
----------------------------------------------------------------------        
FOUND 3 ERRORS AFFECTING 3 LINES                                              
----------------------------------------------------------------------        
 37 | ERROR | Missing short description in doc comment                        
 44 | ERROR | Missing short description in doc comment                        
 57 | ERROR | Missing short description in doc comment                        
----------------------------------------------------------------------        
                                                                              
                                                                              
FILE: tests\options-test.php                                                  
----------------------------------------------------------------------        
FOUND 2 ERRORS AFFECTING 2 LINES                                              
----------------------------------------------------------------------        
 27 | ERROR | Missing short description in doc comment                        
 34 | ERROR | Missing short description in doc comment                        
----------------------------------------------------------------------        

Review visibility of a property and a function

The Clicky_Admin::$hook property as well as the Clicky_Admin::__construct() method, both have an @access private tag, while they are declared as public.

This should be reviewed and either the visibility should be changed or the tag removed.

Admin-side JavaScript conflict with other plugins

Hi team.

Problem

Currently, the plugin loads admin-side JavaScript on every page of the Dashboard
https://github.com/Yoast/clicky/blob/1865da9557244ebfad5f2973e7cd8b44de7c3d11/admin/admin-page.php#L21-L22
https://github.com/Yoast/clicky/blob/1865da9557244ebfad5f2973e7cd8b44de7c3d11/admin/admin-page.php#L30-L39

Since some plugins (like ours) are using URL hashes in navigation, this causes JS error, which breaks functionality of our plugins.

Solution

Load admin-side scripts on plugin settings page only.

Remove the xrstf/composer-php52 dependency

PR #75 drops support for PHP < 5.6.

With that in mind, the xrstf/composer-php52 dependency should be removed, as well as references to the vendor/autoload_52.php file in the clicky.php and tests/bootstrap.php files.

However, while testing this in combination with the changes from #75, the removal the PHP 5.2 autoload file generation is causing some weird problems with the unit tests where the autoload file appears to be loaded twice causing naming clashes ("Cannot redeclare class ....").
See https://travis-ci.org/Yoast/clicky/jobs/619096283 for an example failing build.

This needs further investigation and debugging. The goal should still be to remove the xrstf/composer-php52 dependency which really shouldn't be needed anymore.

Repo missing tag for 1.8

The current version of the plugin on the .org repo is 1.8, however that tag does not exist on this repo. Also the master branch is only up to 1.7.

Minor: Improper Grammar in Readme

Hello,

Very minor just missing 'the' in this string;
https://translate.wordpress.org/projects/wp-plugins/clicky/dev-readme/en-ca/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=3040259&filters%5Btranslation_id%5D=47585666

Removed dashboard widget, added Yoast news widget to settings page.

It should be 'to the settings page';

Removed dashboard widget, added Yoast news widget to the settings page.

Thanks

Make code climate coverage work without a token in the .travis.yml

Context

We currently have a CODECLIMATE_REPO_TOKEN in the .travis.yml. However, that token is unencrypted, and in all other repos we can use code climate's code coverage without having this token.

To do

Make code climate's code coverage work without needing an explicitly set CODECLIMATE_REPO_TOKEN in the .travis.yml.

Only removing the token leads to errors: https://travis-ci.org/github/Yoast/clicky/jobs/664767354#L621-L631. Additional changes to the .travis.yml are needed.

Upgrade tunnel-agent to version 0.6.0 or later

Upgrade tunnel-agent to version 0.6.0 or later.

Running yarn why tunnel-agent shows

=> Found "[email protected]"
info Reasons this module exists
   - "grunt-glotpress#request" depends on it
   - Hoisted from "grunt-glotpress#request#tunnel-agent"
=> Found "caw#[email protected]"
info This module exists because "grunt-contrib-imagemin#imagemin#imagemin-gifsicle#gifsicle#bin-wrapper#download#caw" depends on it.
✨  Done in 0.40s.

Visitor graph image is missing

In my installation of the plugin, the visitor graph image is missing (see attached image)
.

In the page source, the src attribute of the image tag is empty. I'm currently running Wordpress 4.1.5 and the latest version of Clicky by Yoast (Version 1.4.3).

Remove "Text Domain: clicky" from readme.txt

See https://github.com/Yoast/clicky/blob/develop/readme.txt#L7 and the short description on https://wordpress.org/plugins/clicky/.

Use of invalid word 'uniques'

Hey guys,

Was just running through translations and found this string;
https://translate.wordpress.org/projects/wp-plugins/clicky/dev/en-ca/default?filters%5Boriginal_id%5D=3040174

If you don't want Clicky to use cookies on your site, check this button. By doing so, uniques will instead be determined based on their IP address.

Specifically the use of 'uniques' is incorrect as that's not a word.

The string should actually be 'uniqueness';

If you don't want Clicky to use cookies on your site, check this button. By doing so, uniqueness will instead be determined based on their IP address.

Cheers

PHP Warning: Visitor Graph Stats CSS file not found

I'm seeing this warning popping up in the logs quite a bit:

PHP Warning:  include(/.../wp-content/plugins/clicky//css/adminbar.min.css): failed to open stream: No such file or directory in /.../wp-content/plugins/clicky/frontend/class-clicky-visitor-graph.php on line 112

The path is incorrect in v1.8 as css files are in css/dist rather than css. Also, minified versions are not present.

More importantly this should probably be using file_get_contents( css file ) rather than include( css file ) to prevent the contents from being evaluated as PHP.

Release Clicky 1.9

• First tag 1.8 on master to resolve #64
• Then release clicky 1.9. The hypothesis is that the release steps are the same as for ACF: https://github.com/Yoast/Wiki/wiki/Plugin-Release-Process#releasing-additional-plugins-wordpressorg
• Add Clicky release steps to the above wiki.

<noscript> img tag should use https if current page is https

Use WordPress' is_ssl() conditional, don't forget to update the changelog in readme.txt :)