jdryg/angular-pdf-viewer

Just another Angular directive for displaying PDF files using PDF.js

angular-pdf-viewer's Issues

Jumping to next/prev search result

1. Don't scroll the view if the result is already inside the viewport.
2. If it's not in the viewport, scroll to a position a bit above the result (don't put it at the top of the page).

Highlight in all words

Hi,
It possible do highlight in all words in the same time?

Thanks!!

Unicode character, hyperlink, image embed support

This library has very less overhead for PDF generation.
Are you planning to support unicode character, hyperlink, image embed feature in near future?

Text Selection

It throws error when i am trying to integrate in my ionic app. Is it mandatory to include all libraries in ionic?

Print support

It possible to get external pdf file?

I've tried setting "cors" on my server but still can not get it, can you help me?

Thanks!

pdf.worker.js needed but not that is not clearly stated

Hello,

Thanks for all this work, I am trying-out your pdf-viewer, it is very good btw.

Just a note, I think the file pdf.worker.js is needed when implementing the pdf viewer (my browser was looking for it and the issue was gone when I added it in /js/libs/) while it was not obvious (for me) that I would need it. Maybe a line in the Readme to remember us that we need it would be helpful.

Thanks again.

Search doesn't work correctly on some PDFs

Some PDFs have text divs without any text. These divs aren't inserted into the DOM by the text layer builder, but the directive is using them when searching. In other words, text div IDs are invalid when highlighting the results.

Example PDF: citygen_gdtw07.pdf (Citygen: An Interactive System for Procedural City Generation)
Search for: "city"

Line 466. $scope.$apply inside $digest

Sometimes when scrolling, updating the current page index inside $apply (line 466) reports an error. If I remove the $apply call, then the page isn't always updated!

Example of annotation functionality?

Does anyone have an example how to use the annotation layer?
Do I need to use an extra module like pdf-annotate?

a.pdfViewerAPI.getNextZoomInScale is not a function (caused by "undefined")

I am getting very strange error, a.pdfViewerAPI.getNextZoomInScale is not a function (caused by "undefined")

The $scope.pdfViewerAPI = {}; is undefined,

It works as a demo but when I hook it up to my app I get this error.
I use AngularJS v1.2.15;

Transpiler issues error 'This condition will always return 'false''

angular-pdf-viewer/js/angular-pdf-viewer.js

Line 84 in 6a80e19

if (typeof dest === Array) {

When transpiling in typescript, the 'if' statement:
if (typeof dest === Array)
returns the error:
TS2367: This condition will always return 'false' since the types 'string' and 'ArrayConstructor' have no overlap.
I believe the statement should be changed to
if (dest instanceof Array)
as is done elsewhere in the code.

upgrade pdf.js to latest

Please provide instruction for upgrading to later PDF.js versions, if possible.

Have you attempted to upgrade to the latest PDF.js? I swapped in 1.3.88 and 1.2.109 but the promises never seemed to fire. Are there changes that need to be made to PDF.js to make it compatible with this codebase?

Annotations

PDF.js viewer does it, so we should be able to do it too. Check pdf.js/web/annotations_layer_builder.js

Remove pages during scrolling

Since have lazy rendering in place, we might want to remove canvases and text layers for pages which aren't close to the viewport. This might speed things up with large documents.