jedfonner/mattermostonfire

Firebase Realtime Database and Firebase Cloud Function code to power a Mattermost slash command for creating a poll using Mattermost Interactive Buttons.

mattermostonfire's Issues

Multiple choices?

After using MattermostOnFire for some weeks, some users asked for a flag to allow multiple answers per vote. As an example:

/poll Anyone for lunch today? | Pizza | Pasta | Burger | Vegan | multiple=true

or a second shash command /pollsingle and /pollmutiple

would allow the user to vote for Pizza and Burger. As before, the answer with the most votes wins.

Just an idea for a future version...

Double-encoding in vote confirmation message

Observed
An apostrophe in a vote option label gets double-encoded in the vote confirmation message. See screenshot.

Expected
All characters should be displayed the same in the confirmation message as in the option label.

Cannot deploy project

Hi, @jedfonner !

Thanks for this, I´d really like to try it out but I wasn´t able to deploy the project to Firebase. Do you have any idea what´s going wrong here?

I just edited .firebasrc, set my project name and tried to deploy with firebase deploy.
The firebase login was ok. My Node version is 8.9.3 on Windows.

=== Deploying to 'mattermostonfire-13513'...

i  deploying database, storage, firestore, functions, hosting
i  database: checking rules syntax...
+  database: rules syntax for database mattermostonfire-13513 is valid
i  storage: checking storage.rules for compilation errors...
+  storage: rules file storage.rules compiled successfully
i  firestore: checking firestore.rules for compilation errors...
+  firestore: rules file firestore.rules compiled successfully
i  functions: ensuring necessary APIs are enabled...
+  functions: all necessary APIs are enabled
i  storage: uploading rules storage.rules...
i  firestore: uploading rules firestore.rules...
i  functions: preparing functions directory for uploading...

Error: Error occurred while parsing your function triggers.

TypeError: Cannot read property 'token' of undefined
    at Object.<anonymous> (C:\Users\xxx\AppData\Local\Temp\fbfn_9072E2sI87dyCPBP\utils.js:3:59)
    at Module._compile (module.js:635:30)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (C:\Users\xxx\AppData\Local\Temp\fbfn_9072E2sI87dyCPBP\index.js:3:15)
    at Module._compile (module.js:635:30)

Regards,
Markus

Firebase Node

If I want to run the command firebase login, the command does not exist.
All the dependencies are installed, I run node version 10.7.0 and npm 6.1.0.

Internationalisation?

Hi Jed,

I would like to translate this into German language and thought, the easiest approach would be a forked translated project (as I don´t see any localisation structures in the source code). For my demands, this would be sufficient.

If there would be any demand for other localized versions, it would probably be a better idea to prepare the project to support multiple languages... Perhaps, the user´s language from the Mattermost client could even be transferred to MattermostOnFire?

Regards,
Markus