jefking/arm-builder

Build Azure ARM Templates

arm-builder's Issues

Template generator should not add dashboard setting for V2 Function App

The AzureWebJobsDashboard setting is a legacy setting that should not be used for V2 function apps.

Add node specific settings for node function app

Assuming the user pointed the tool at a node.js function app, then the generated ARM template should contain these settings:

            {
              "name": "FUNCTIONS_WORKER_RUNTIME",
              "value": "node"
            },
            {
              "name": "WEBSITE_NODE_DEFAULT_VERSION",
              "value": "10.14.1"
            },     

Generated template for function app uses non-existent param

There seems to be an issue with the generated parameters/variables that prevents the ARM template from working:

  "parameters": {
    "siteName": {
      "type": "string",
      "metadata": {
        "description": "The name of the function app that you wish to create."
      }
    }
  },
  "variables": {
    "functionAppName": "[parameters('appName')]",
    "hostingPlanName": "[concat(parameters('appName'), '-plan')]",
    "applicationInsightsName": "[parameters('appName')]",
    "storageName": "[concat('function', uniqueString(parameters('siteName')))]",
    "contentShareName": "[toLower(parameters('siteName'))]",
    "repoUrl": "https://github.com/paulbatum/pull-request-reviewer",
    "branch": "master"
  },

Note that it defines a siteName parameter but then the variables refer to appName.