Giter Site home page Giter Site logo

Comments (6)

JEG2 avatar JEG2 commented on June 19, 2024

Wow, you really type passwords like that? :)

It's true that we have to setup some special terminal modes to avoid echoing the password. That swallows some key combinations. I have found that to be a problem thus far, but I'll take patches from people it bothers who can find a way around it.

from highline.

abinoam avatar abinoam commented on June 19, 2024

Hi @gutenye , just to be sure I'm understanding correctly. Are you expecting HighLine to "delete" all the line and come back to "home", so it would return only "world", not "hello\u0015world" ?

If so, I think we could try to do this.
But, should we try to emulate all control keys from the terminal?

For most common purposes of the echo = false use cases, handling backspace correctly is enough.

from highline.

JEG2 avatar JEG2 commented on June 19, 2024

Yeah, I'm not sure how much it's HighLine's responsibility to emulate full terminal behavior. It seems weird to me that a simple HighLine call might erase my terminal screen.

We are currently planning the next major version of HighLine. We will include a discussion of where to draw these lines in the plans we make for that release.

from highline.

gutenye avatar gutenye commented on June 19, 2024

Are you expecting HighLine to "delete" all the line

Yes, that's what I wanted.

from highline.

abinoam avatar abinoam commented on June 19, 2024

Hi @gutenye,

Most projects that I know just delete (deprecate) old issues. But it's not the case here in HighLine. We don't give up! 😄
This issue has more than 10 years! Oh - MY - GOD!

The first release of "io/console" was 0.3 at October 16, 2011 (6,5 KB). But, not mature, and in a time that some of the releases were yanked.

The first "usable" release that I have notice is 0.4.1 at February 04, 2013 (8,5 KB) AFTER the opening of this issue.

You can see the whole release history at https://rubygems.org/gems/io-console/versions

The good news is that we currently have an "io/console" more mature with more features we could rely on so we don't have to take all the responsibilities for the console inside HighLine's code.

I've just merged a PR that solves handling "CTRL-C" by relying on "io/console" functionalities that were released with Ruby version 2.7.0 at December, 2019 (when this issue had 7 years old.
Then I remembered about this old issue over here and this improvements in "io/console" gave me some hope.
I can't promise, but I'll be trying to solve it.

Is there any GitHub badge for solving a 10 years old issue? 😄

Hey @JEG2 keep an eye on this? Perhaps we take a picture of an "anniversary cake" for the issue.

from highline.

abinoam avatar abinoam commented on June 19, 2024

It was easier to treat CTRL-U as we are treating backspace now than to rely on io/console. Basically because of things like the possibility of echo = '*' for example, or question.limit. But we surely have to transition on to relying on io/console for everything it is possible now. Se PR #260

from highline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.