choose prints "Ignored" instead of choices on JRuby

[jeg2]

choose prints "Ignored" instead of choices on JRuby

[JEG2]

Can you try it outside of a console (inside a script file that you feed to the JRuby interpreter) and report back if you are seeing the same thing?

[andlaz]

Andras-rMBP:~ andras$ jruby highline.rb 
Ignored
Ambiguous choice.  Please choose one of ["1", "2", "3", :ruby, :python, :perl].
?  Ignored
Ambiguous choice.  Please choose one of ["1", "2", "3", :ruby, :python, :perl].
?  Ignored1
Good choice!

thanks!

[JEG2]

Good to know. Thanks.

This definitely needs fixing.

[jeremyd]

I have the same issue. Prints ignored but menu still responds to enter key.
jruby 1.7.1 (1.9.3p327) 2012-12-03 30a153b on OpenJDK 64-Bit Server VM 1.6.0_24-b24 [linux-amd64]

[jeremyd]

I've tracked this down to the code here: https://github.com/JEG2/highline/blob/master/lib/highline.rb#L253

The comment in the code seems to indicate that it's attempting to avoid a JRUBY bug however the logic means that no @question is displayed other than "Ignored" when used with highline's default settings. I noticed that when I switch to using readline=true on my menu AND I hack this line https://github.com/JEG2/highline/blob/master/lib/highline.rb#L253 to remove the JRUBY check that the choices are displayed. This leaves me with a few more questions:

Can someone who's familiar with how the options work for echo and readline inspect this logic on line 253 to see if it makes sense? I'd like to see it deal with JRUBY+readline but at the same time not cause issues with the echo stuff.

Is there a way to globally default to using readline for ALL questions? IE: even the alias to "agree("question?")" default to readline=false and this causes the question not to display the prompt in jruby.

[JEG2]

I didn't write that particular check, so I'm afraid I don't remember what the logic is doing there.

I do plan to look into this next time I find the time for a HighLine bug fix. Obviously, several issues have built up.

[rsutphin]

With #67 applied, many of the tests that fail on JRuby 1.7.3 seem to be demonstrating some variant of this problem.

[kgx]

+1 having same issue on JRuby 1.7.2 on Mountain Lion

[deckchairhq]

+1 - This is a blocker for me as I package using Warbler. Unfortunately i'm not upto speed on the intricacies of JRuby and the CLI but i'll have a look anyway.

[abinoam]

Hi @andlaz and all,

We are trying to "regain" JRuby compatibilitty at this PR #149
I've tested your code on my machine, a mac os x with jruby 1.7.20 (1.9.3p551) 2015-05-04 3086e6a on Java HotSpot(TM) 64-Bit Server VM 1.6.0_65-b14-462-11M4609 +jit [darwin-x86_64]
... and it's working fine.

Could you confirm if it's fixed so we could close this issue?

[abinoam]

Closing as it's fixed.