Highline v1.6.2 Error

[jeg2]

Highline v1.6.2 Error

[JEG2]

If you want to work up a patch for this I'm happy to apply it.

[davispuh]

I wouldn't say it's HighLine bug. You're passing Hash to format_statement but it doesn't make sense. It's supposed to be a string. Why Hash?

[JEG2]

That's a fair point. I didn't look at that error message closely enough.

[bsodmike]

It's bubbling up through from Vagrant's use of Berkshelf

[chef] Destroying VM and associated drives...
[chef] Running cleanup tasks for 'chef_solo' provisioner...
/Users/mdesilva/.vagrant.d/gems/gems/highline-1.6.20/lib/highline.rb:711:in `format_statement': undefined method `to_str' for {"chef-server"=>"2.0.0"}:Hash (NoMethodError)
    from /Users/mdesilva/.vagrant.d/gems/gems/highline-1.6.20/lib/highline.rb:617:in `say'
    from /Users/mdesilva/.vagrant.d/gems/gems/solve-0.8.1/lib/solve/tracers/human_readable.rb:43:in `solution'
    from /Users/mdesilva/.vagrant.d/gems/gems/solve-0.8.1/lib/solve/solver.rb:124:in `resolve'
    from /Users/mdesilva/.vagrant.d/gems/gems/solve-0.8.1/lib/solve.rb:39:in `it!'
    from /Users/mdesilva/.vagrant.d/gems/gems/berkshelf-2.0.10/lib/berkshelf/resolver.rb:102:in `resolve'
    from /Users/mdesilva/.vagrant.d/gems/gems/berkshelf-2.0.10/lib/berkshelf/berksfile.rb:671:in `resolve'
    from /Users/mdesilva/.vagrant.d/gems/gems/berkshelf-2.0.10/lib/berkshelf/berksfile.rb:418:in `install'`

[JEG2]

Then we probably need to submit a bug to them, don't you think?

[abinoam]

The main output method in Ruby is #puts.
#puts accepts anything as argument and it just convert it into a String.
So, when we see #say or #ask we naturally think we can pass any arbitrary object, like the hash that was being passed in https://github.com/berkshelf/solve/blob/v0.8.1/lib/solve/tracers/human_readable.rb#L43 and was fixed here berkshelf/solve@6d75408 just to work along with HighLine.
What about to give #say some of the #puts superpowers?

The current problem is that #say is trying to #dup and #to_str the arguments. But some objects have problems with #dup, and others have problems with #to_str.

So, I tried to improve on this by first calling String (conversion method), and #dup only after we have a String.