jellyfin-archive/emby-plugin-tunein

emby-plugin-tunein's Issues

Help on porting this to Jellyfin

Does anyone have a link to info on how I can help porting this to work with jellyfin?

Need partner ID from TuneIn for some API requests

The plugin is currently using a TuneIn partner ID that is associated with Emby, probably a good idea to stop using it.

The main use of the partner ID appears to be to increase or effectively remove the rate limit on API requests, and allow access to a user's presets through the TuneIn API (attempting to access user presets without a valid partner ID results in a 403 Forbidden response from the API).

The rest of the plugin works fine without a partner ID, but we could still get one, although it seems instructions on how to get a partner ID for this use case haven't been updated since 2011.
(see http://web.archive.org/web/20110805190912/http://inside.radiotime.com/developers/start).

It might be possible to obtain a partner ID by submitting a request on this page, under "Device Partners": https://tunein.com/contact/

PR #2 has the partner ID temporarily removed from API requests.

Radio stations won't play without container/audiocodec set

Jellyfin will fail to play an internet radio stream if the URL doesn't contain a file extension and the MediaSourceInfo does not have the Container and AudioCodec properties set to a valid audio codec, e.g. aac or mp3.

In PR #2 this is partially fixed by attempting to identify the correct audio codec from the file path/URL, and defaulting to aac.

This could be improved later, perhaps taking advantage of the TuneIn API.

Need to update URLs, for default images and others

GetDefaultImages() in TuneInChannel.cs currently returns URLs for images that are located in a personal git repository. This should be changed to point to an official source for the images, perhaps this repository? With Jellyfin now supporting .zip plugin packages, they could potentially be included in this plugin's zip file, or even built in to the .dll file if possible.

The TuneIn API seems to work fine over https, yet all the API requests in this plugin use http. Seems like a harmless change to use https for them, for the small amount of security it might add.

PR #2 changes the image URLs to point to this repository, and changes all TuneIn URLs to use https.

Not handling extended m3u playlists properly

A loop in GetChannelItemMediaInfo() in TuneInChannel.cs that pulls file paths from an m3u playlist will throw an exception if it encounters any extended m3u lines, since it treats them as regular file paths.
(see https://en.wikipedia.org/wiki/M3U#Extended_M3U)

In PR #2 this is fixed, as any lines in an m3u playlist beginning with a hash (#) symbol are ignored.

(Not sure why this plugin is handling these playlist files on its own or if they could just be passed on for Jellyfin to deal with)

Not handling .pls playlists properly

This plugin handles .pls playlists incorrectly in a number of places, preventing the playback of some radio stations:

• If "Version=2" appears multiple times in a .pls file (which it often does), an exception is thrown in the IniParser class, due to the use of a Hashtable to store key-value pairs (only one of each key is allowed).
• IniParser converts all keys and values to uppercase, and this plugin subsequently converts them back to lowercase, ruining any case-sensitive file paths or URLs in a playlist.
• A loop in GetChannelItemMediaInfo() in TuneInChannel.cs that extracts media items from a .pls playlist begins at 0, however, .pls files appear to be 1-indexed and begin with "File1", resulting in a null media item whenever a .pls file is opened due to an attempt to get the path of "File0".
  (see https://en.wikipedia.org/wiki/PLS_(file_format) )

These problems have fixes in PR #2:

• IniParser now silently ignores duplicate keys in a .pls file
• IniParser no longer converts values to uppercase. Keys are still converted to uppercase
• The loop in TuneInChannel is now 1-indexed.

(Not sure why this plugin is handling these playlist files on its own or if they could just be passed on to Jellyfin to deal with)