jemaja/weekmenu

A Spring Boot application to manage and create the weekly menu at home

weekmenu's Issues

DayRecipe API controller

List all recipes in a page

make visible if a recipe is accepted or conditional

period page layout not nice on mobile device

For a single day, the date, recipe and options button are shown on different lines, where this should fit on a single line.

Improve flow in menucontroler

Currently, each time the page is loaded, the system will connect to the DB and try to insert each DayRecipe, this is unneeded overhead and could be done in a smarter way

Navigation handled globally

Application not starting after merge issues

2022-12-11 13:02:34.887 ERROR 39604 --- [ main] o.s.boot.SpringApplication : Application run failed

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'entityManagerFactory' defined in class path resource [org/springframework/boot/autoconfigure/orm/jpa/HibernateJpaConfiguration.class]: Invocation of init method failed; nested exception is org.hibernate.service.spi.ServiceException: Unable to create requested service [org.hibernate.engine.jdbc.env.spi.JdbcEnvironment]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1804) ~[spring-beans-5.3.22.jar!/:5.3.22]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:620) ~[spring-beans-5.3.22.jar!/:5.3.22]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542) ~[spring-beans-5.3.22.jar!/:5.3.22]
at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335) ~[spring-beans-5.3.22.jar!/:5.3.22]
at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234) ~[spring-beans-5.3.22.jar!/:5.3.22]
at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333) ~[spring-beans-5.3.22.jar!/:5.3.22]
at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208) ~[spring-beans-5.3.22.jar!/:5.3.22]
at org.springframework.context.support.AbstractApplicationContext.getBean(AbstractApplicationContext.java:1154) ~[spring-context-5.3.22.jar!/:5.3.22]
at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:908) ~[spring-context-5.3.22.jar!/:5.3.22]
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583) ~[spring-context-5.3.22.jar!/:5.3.22]
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:147) ~[spring-boot-2.7.2.jar!/:2.7.2]
at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:734) ~[spring-boot-2.7.2.jar!/:2.7.2]
at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:408) ~[spring-boot-2.7.2.jar!/:2.7.2]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:308) ~[spring-boot-2.7.2.jar!/:2.7.2]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1306) ~[spring-boot-2.7.2.jar!/:2.7.2]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1295) ~[spring-boot-2.7.2.jar!/:2.7.2]
at nl.jemaja.weekmenu.WeekmenuApplication.main(WeekmenuApplication.java:13) ~[classes!/:1.0.2-BETA]
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:na]
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:na]
at java.base/java.lang.reflect.Method.invoke(Method.java:566) ~[na:na]
at org.springframework.boot.loader.MainMethodRunner.run(MainMethodRunner.java:49) ~[weekmenu-1.0.2-BETA.jar:1.0.2-BETA]
at org.springframework.boot.loader.Launcher.launch(Launcher.java:108) ~[weekmenu-1.0.2-BETA.jar:1.0.2-BETA]
at org.springframework.boot.loader.Launcher.launch(Launcher.java:58) ~[weekmenu-1.0.2-BETA.jar:1.0.2-BETA]
at org.springframework.boot.loader.JarLauncher.main(JarLauncher.java:65) ~[weekmenu-1.0.2-BETA.jar:1.0.2-BETA]
Caused by: org.hibernate.service.spi.ServiceException: Unable to create requested service [org.hibernate.engine.jdbc.env.spi.JdbcEnvironment]
at org.hibernate.service.internal.AbstractServiceRegistryImpl.createService(AbstractServiceRegistryImpl.java:275) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.service.internal.AbstractServiceRegistryImpl.initializeService(AbstractServiceRegistryImpl.java:237) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.service.internal.AbstractServiceRegistryImpl.getService(AbstractServiceRegistryImpl.java:214) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.id.factory.internal.DefaultIdentifierGeneratorFactory.injectServices(DefaultIdentifierGeneratorFactory.java:175) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.service.internal.AbstractServiceRegistryImpl.injectDependencies(AbstractServiceRegistryImpl.java:286) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.service.internal.AbstractServiceRegistryImpl.initializeService(AbstractServiceRegistryImpl.java:243) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.service.internal.AbstractServiceRegistryImpl.getService(AbstractServiceRegistryImpl.java:214) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.boot.internal.InFlightMetadataCollectorImpl.(InFlightMetadataCollectorImpl.java:173) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.boot.model.process.spi.MetadataBuildingProcess.complete(MetadataBuildingProcess.java:127) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.jpa.boot.internal.EntityManagerFactoryBuilderImpl.metadata(EntityManagerFactoryBuilderImpl.java:1460) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.jpa.boot.internal.EntityManagerFactoryBuilderImpl.build(EntityManagerFactoryBuilderImpl.java:1494) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.springframework.orm.jpa.vendor.SpringHibernateJpaPersistenceProvider.createContainerEntityManagerFactory(SpringHibernateJpaPersistenceProvider.java:58) ~[spring-orm-5.3.22.jar!/:5.3.22]
at org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean.createNativeEntityManagerFactory(LocalContainerEntityManagerFactoryBean.java:365) ~[spring-orm-5.3.22.jar!/:5.3.22]
at org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.buildNativeEntityManagerFactory(AbstractEntityManagerFactoryBean.java:409) ~[spring-orm-5.3.22.jar!/:5.3.22]
at org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.afterPropertiesSet(AbstractEntityManagerFactoryBean.java:396) ~[spring-orm-5.3.22.jar!/:5.3.22]
at org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean.afterPropertiesSet(LocalContainerEntityManagerFactoryBean.java:341) ~[spring-orm-5.3.22.jar!/:5.3.22]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1863) ~[spring-beans-5.3.22.jar!/:5.3.22]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1800) ~[spring-beans-5.3.22.jar!/:5.3.22]
... 24 common frames omitted
Caused by: org.hibernate.HibernateException: Access to DialectResolutionInfo cannot be null when 'hibernate.dialect' not set
at org.hibernate.engine.jdbc.dialect.internal.DialectFactoryImpl.determineDialect(DialectFactoryImpl.java:100) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.engine.jdbc.dialect.internal.DialectFactoryImpl.buildDialect(DialectFactoryImpl.java:54) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.engine.jdbc.env.internal.JdbcEnvironmentInitiator.initiateService(JdbcEnvironmentInitiator.java:138) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.engine.jdbc.env.internal.JdbcEnvironmentInitiator.initiateService(JdbcEnvironmentInitiator.java:35) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.boot.registry.internal.StandardServiceRegistryImpl.initiateService(StandardServiceRegistryImpl.java:101) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
at org.hibernate.service.internal.AbstractServiceRegistryImpl.createService(AbstractServiceRegistryImpl.java:263) ~[hibernate-core-5.6.10.Final.jar!/:5.6.10.Final]
... 41 common frames omitted

Planning stops when no recipe found

If on a workday, no recipe for workdays is found, it will not continue planning the next day. The planning just stops.
It should try to plan the next they, since this could be a saturday!

Initial load of period does not show recipes, even if they are planned

Issue with transactions and commits on loading of DayRecipe Class

The DayRecipe class holds the recipe which is planned for a given date + status information.

there is a number of actions which Updates the DayRecipe records, and should return the updated version. However they return the version from before the update.
Hence it seems something with transactions or commits is going wrong.

Example1:
When the root URL is opened for a date range, which is new/ not loaded before, the controller will initiate the DayRecipe Records.
These will have recipe NULL.
Next the controller method will call the fuction to schedule dinners. This will ensure Recipe != null and status =1
After this action, the controller will find the DayRecipe's and pass them to the model for the frontend.
However, what is passed is recipe NULL, so the inital version.

After a refresh, the creation and planning steps will be skipped, and now it returns the correct recipe.

Example 2:
If a DayRecipe has status = 1 and Recipe != null.
The suggested recipe can be accepted (status =2) by an API PUT call to:
localhost:8080/api/v1/dayrecipe/accept/{ID}
(In class) DayRecipeRestControllerV1
This will update the status to 2, and return the record.
But here again, it returns the Pre-updated record instead of the actual record.

Updating a recipe on a DayRecipe does not update last_eaten_date on old recipe

If a recipe was planned and a user chooses a different recipe. It does not update the last eaten date for the recipe being removed.

Reduce DB calls for longestPlanDay()

In PlannerService.longestPlanDay()
allow Map to be passed as a parameter, and also return the map.

Currently, if we plan for multiple days in a row, it will query the DB for each day x each recipe to find the last eaten date.
While actually only the recipe used the day before is changed.

New approach:
-Pass the Map as input
-If the map is empty, query DB for all recipes last eaten
-If the map is not empty, assume it is correct and use it to plan. (sort it by key)
-After planning, update the key of the recipe used in the map
-Take into account new recipes. All new recipes will get date 1-1-1970, however only 1 is stored. So we always need to query for new recipes which are not yet in the map, and add them

Modify Recipe

Re-use the page for new recipes.

• Pass an additional param in the DTO to pass the ID.
• Update the save recipe procedure in the service. If it gets an existing ID, it should update the name where required

InfoDto block should be handled generically and closable

InfoDto block should be handled generically and closable

Main page date range functionallity

The main page requires functionality to select a date range for which the DayRecipe's are shown
The controller already supports a from date (String f) and to date (String t) as get parameters.
However does not handle them yet.

To do:

• MenuController class: add functionality to method to process the input
• Frontend: add datepickers in the menu on a nice place

Ingredient API fpr CRUD

Upon taking an action in the period overview screen for a given day, the range navigator is forgotten

For example, in the period / main screen selected next week in the date range picker.
Correctly shows this range.
Now if we set another recipe for a day, when the page is redirected, it should redirect to the same date range, however it does not, it returns to default.

Date range resets upon choosing other recipe

If you currently are in a custom date range, and you use the choose other recipe function. The page reloads to the standard range (next 14 days)

it should reload to the previous custom range.

Probably something in period.js not passing the parameters?

Stacktrace printed to console when no recipe is found in main page

When no recipe is found in the main page.
A stack trace is logged in the console.
This is not needed. Just logging to Debug and Warning is sufficient

Error thown when choosing other recipe first time

When you use the option: Choose Other Recipe in the period screen.
On the first time another recipe is selected, an error 404 is trown.
URL looks like:
localhost:8080/;jsessionid=EB21CC0A9257CF5BA5C225D7026F8F97

second time error does not occur

Move API controller to it's own package

And add /API/v1/ to base url

RecipeLabel API for CRUD

crash if no recipe is selected in update recipe popup

Add incorrect status exception

recipe always needs to be active

Not possible yet to modify this flag, but it is needed for planning.
Currently default set to true.

Incorrect sort order of dates in period