jemc/pony-rope

Pony implementation of a rope data structure for efficient, zero-copy manipulation of byte buffers.

pony-rope

Pony implementation of a rope data structure, with an emphasis on efficient, zero-copy manipulation of byte buffers.

pony-rope's Issues

errors in partial calls on the "normal" code paths

From my understanding, we want to avoid errors being raised in the normal code paths, e.g. when the iterator here

pony-rope/rope/rope.pony

Line 46 in 3f38d84

fun ref next(): U8? => try _left_values.next()?

has reached the right branch of the rope tree, the error will always be raised.

a check against _left_values.has_next() would even out the performance across both branches

      fun ref next(): U8?      => if _left_values.has_next() then _left_values.next()? // "normal" use would trigger the error condition when the iterator has reached the right branch of the tree, so checking has_next() before next() prevents the error from being raised
                                  else _right_values.next()? // error is still propagated
                                  end