jenmcquade/aspnetcore-react-redux

Boilerplate for C# ASP .NET Core MVC SPA with TypeScript, React and Redux

aspnetcore-react-redux's Issues

Serve dist files with gzip

File sizes can be minimized further by gzipping the files and correctly setting their cache times.

Visual Studio Build errors

Hi Jon,

Firstly,this looks a really good project, big thank you (I am using it as a boilerplate to learn from)
However, I am struggling to get it to build either in VS Community 2017 Preview (V15.7.0 Preview 2.0)
on Windows 10 (latest build) with .Net Core 2.1, NPM 5.60, Node v8.11.1, Webpack 4.5.0, TypeScript 2.8 or via docker (Prod or Dev)

I appreciate that you have posted this up on GitHub and I feel like I should be able to work it out but I am struggling a bit.

NPM errors via Windows Powershell

PS C:\Users\James\Documents\Visual Studio 2017\Projects\Preview\aspnetcore-react-redux-master\src> npm install
npm WARN [email protected] requires a peer of ajv@^5.0.0 but none is installed. You must install peer dependencies your
self.
npm WARN [email protected] requires a peer of webpack@^1.13.2 || ^2.1.0-beta || ^3.0.0 but none is installed. You mus
t install peer dependencies yourself.
npm WARN [email protected] requires a peer of webpack@^2.2.0 but none is installed. You must install peer depen
dencies yourself.
npm WARN [email protected] requires a peer of babel-eslint@^7.2.3 but none is installed. You must install pe
er dependencies yourself.
npm WARN [email protected] requires a peer of eslint-plugin-jsx-a11y@^5.1.1 but none is installed. You must
install peer dependencies yourself.
npm WARN [email protected] requires a peer of react@>=0.13.0 <16.0.0 but none is installed. You must install peer depende
ncies yourself.
npm WARN [email protected] requires a peer of moment@^2.8.3 but none is installed. You must install peer dependencies you
rself.
npm WARN [email protected] requires a peer of webpack@^1.0.0 || ^2.0.0 || ^3.0.0 but none is installed. You
must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any
"} (current: {"os":"win32","arch":"x64"})

up to date in 12.053s

Not sure if these are just warnings but the npm folder does not load in VS 2017 Preview (yellow triangle) and I get the following build errors.

VS 2017 Preview build errors

Severity	Code	Description	Project	File	Line	Suppression State
Error	CS7064	Error opening icon file C:\Users\James\Documents\Visual Studio 2017\Projects\Preview\aspnetcore-react-redux-master\src\wwwroot\favicon.ico -- Could not find file 'C:\Users\James\Documents\Visual Studio 2017\Projects\Preview\aspnetcore-react-redux-master\src\wwwroot\favicon.ico'.	flightsearch	C:\Users\James\Documents\Visual Studio 2017\Projects\Preview\aspnetcore-react-redux-master\src\CSC	1	Active

Severity	Code	Description	Project	File	Line	Suppression State
Error	TS5055	Cannot write file 'C:/Users/James/Documents/Visual Studio 2017/Projects/Preview/aspnetcore-react-redux-master/src/ClientApp/registerServiceWorker.js' because it would overwrite input file.	C:\Users\James\Documents\Visual Studio 2017\Projects\Preview\aspnetcore-react-redux-master\src (tsconfig or jsconfig project)		1	Active

Severity	Code	Description	Project	File	Line	Suppression State
Error	TS5055	Cannot write file 'C:/Users/James/Documents/Visual Studio 2017/Projects/Preview/aspnetcore-react-redux-master/src/webpack.config.js' because it would overwrite input file.	C:\Users\James\Documents\Visual Studio 2017\Projects\Preview\aspnetcore-react-redux-master\src (tsconfig or jsconfig project)		1	Active

Severity	Code	Description	Project	File	Line	Suppression State
Error	TS5055	Cannot write file 'C:/Users/James/Documents/Visual Studio 2017/Projects/Preview/aspnetcore-react-redux-master/src/webpack.config.vendor.js' because it would overwrite input file.	C:\Users\James\Documents\Visual Studio 2017\Projects\Preview\aspnetcore-react-redux-master\src (tsconfig or jsconfig project)		1	Active

btw Tacoma (and the whole pacfic nw) looks a great place - on my list of places to visit!

Cheers and Thanks again for a great project

James

Service Worker is not being registered on HTTPS

Lighthouse says this is a fail in Progressive Web App category.

Dockerize installation

Some complaints from cohorts that their .NET environment is conflicting with this .NET Core App's installation, so Dockerize the solution and installation inside of a .NET Core container, and add binding to local host.

Update jQuery

Older package has vulnerabilities.

Remove Webpack 4 as a Global Dependency

Modify any instructions for Webpack builds so they point to the local node_modules folder

Manifest file is missing in prod

Vendor manifest appears to be there, but not the main app manifest. This might be resolved when serviceWorker is registered.

HTTP traffic should redirect to HTTPS

Currently, HTTPS is available through Heroku. However, either the app or a reverse proxy needs to implement HTTP detection and redirect as a 301 to HTTPS.

Vulnerability in dependency of dependency

hapijs / hoek

in src/package-lock.json : Known security vulnerability in 2.16.3

Make menu responsive

Menu column should reduce to a horizontal row when targeting styles through media queries of 767px or smaller.

Hot Module Replacement doesn't get triggered through Docker shared volumes

"HMR Connected" is displayed in Developer Tools, but when a file change is saved, it doesn't trigger a rebuild and injection from WebPack.

This behavior is only present when using Docker containers for development. HMR works when developing locally.