jensastrup/pyechosign

pyechosign's Issues

get_agreements() errors if there are no agreements.

If there are no agreements for an account, or if you pass in a query parameter that does not match an agreement, this error is thrown.

  File "/home/rtaft/venv/local/lib/python2.7/site-packages/pyEchosign/classes/account.py", line 72, in get_agreements
    return Agreement.json_to_agreements(self, response_body)
  File "/home/rtaft/venv/local/lib/python2.7/site-packages/pyEchosign/classes/agreement.py", line 146, in json_to_agreements
    json_data = json_data.get('userAgreementList')
AttributeError: 'list' object has no attribute 'get'

The response is and empty list []

TransientDocument constructor fails

  File "temp/echosign.py", line 76, in send_doc_for_signature
    document = TransientDocument(account, filename, open(filepath + '/' + filename, 'r'), 'application/pdf')
  File "/home/rtaft/venv/local/lib/python2.7/site-packages/pyEchosign/classes/documents.py", line 72, in __init__
    self.expiration_date = today.replace(days=+7).datetime
  File "/home/rtaft/venv/local/lib/python2.7/site-packages/arrow/arrow.py", line 622, in replace
    raise AttributeError('unknown attribute: "{}"'.format(key))
AttributeError: unknown attribute: "days"

This should be calling shift instead of replace

get_library_documents module - AttributeError - When the document list returned is empty

The error is the following:

File "/usr/local/lib/python3.7/site-packages/pyEchosign/classes/library_document.py", line 78, in json_to_agreements response_data = json_data.get('libraryDocumentList') AttributeError: 'list' object has no attribute 'get'

Cheers :)

Update README

The current README uses the class Recipient which does not exist. I believe this should be User.

INVALID_ACCESS_TOKEN not handled properly

When creating the EchosignAccount, I'm getting the following error:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/rtaft/venv/local/lib/python2.7/site-packages/pyEchosign/classes/account.py", line 38, in __init__
    self.api_access_point = response_body.get('api_access_point') + endpoints.API_URL_EXTENSION
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

This is due to the fact that the API is returning a 401 and errors are not handled at all:
{"code":"INVALID_ACCESS_TOKEN","message":"Access token provided is invalid or has expired"}

Update to API v6

API v6 is available. It will take a bit more than just changing the version number.

Access-Token: <token> has been replaced with Authorization: Bearer <token>
/base_uris is now /baseUris
api_access_point is now apiAcessPoint
several other changes where the formatting has changed from underscore to camelCase

https://www.adobe.io/apis/documentcloud/sign/docs.html#!adobedocs/adobe-sign/master/api_usage/api_change_log.md

Add support to fetch a single Agreement

Currently pyEchosign is able to fetch all Agreements, but not a single one using the agreementId. Add support for this.

LibraryDocument fields always false

When trying to use LibraryDocument fields document and form_field_layer, they are always false.

Multiple signers does not work

The documentation for Agreement.send says:

recipients: A list of :class:`Users <pyEchosign.classes.users.User>`.
                The order which they are provided in the list determines the order in which they sign.

However, having multiple recipients actually allows either to sign, not each in order.