This is an excellent project, nothing like this in the Delphi community as far as I kn

Het <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url=

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

XE4 compilation error: System.Console.pas(83): E2003 Undeclared identifier: 'vkPeriod' about delphiconsole HOT 16 CLOSED

jensborrisholt commented on June 5, 2024 1

XE4 compilation error: System.Console.pas(83): E2003 Undeclared identifier: 'vkPeriod'

from delphiconsole.

Comments (16)

checkdigits commented on June 5, 2024 2

I'll look again on Monday and see if I can get a copy of XE4 and I'll fix this.

In theory my MVP licenses allow me to download and install all versions but, ironically, a bug in the license server prevents me from activating the copy! (Not cool after a several GB download). Ironically I did have XE3 and XE4 installed until only a few weeks ago but I deleted them to save some space.

That internal error can be triggered by several things. I agree generics might well cause it a problem but there's a number of other things too which don't relate to the actual syntax in the source.

When I get XE4 installed again I'll fix the bits you mentioned @edwinyzh wrapping them so Rio and later works too and then submit a pull request. It'll be a few days before I can get to it.

This project is worth the effort - if it can be made to work for older compilers, that would be great. If it can't be done at least it will not be for want of us trying! 😃 👍

from delphiconsole.

checkdigits commented on June 5, 2024 1

Not sure about XE4 but it sounds like you're missing the include for system.UITypes (documented here: http://docwiki.embarcadero.com/Libraries/Rio/en/System.UITypes)

That unit defines the following for vkPeriod:

const vkPeriod: Integer = $BE;

from delphiconsole.

JensBorrisholt commented on June 5, 2024 1

First of all thank you for your kind words. Like I've stated in the intro text the inspiration came from C#. After have made console applications in C# for a while I returned to Delphi and found out hvw low level console programming was in Delphi. So I decided to make this class. I simple "stole" the interface definition from C# and then started programming :D

About the issue:
It seems like vkPeriod has come into System.UITypes Later on. I don't have access to a Delphi XE 4 compiler so I can't test if any thing else is missing.

Would you please add this to your source code:
{$IF CompilerVersion < 23}
const
vkPeriod = $BE;
{$IFEND}

And tell me if that solves the problem. When we have it all sorted out I'll update the Repo.

from delphiconsole.

edwinyzh commented on June 5, 2024 1

I think it's a very valid and good approach to port/borrow ideas from the c# world :D

I worked around the virtual key constants errors by adding the following:

// XE4's CompilerVersion is 25
{$IF CompilerVersion <= 25}
const
  vkPeriod = $BE;
  vkPara =  $DF;
  vkOem102 =  $E2;
{$IFEND}

But still encounter a compiler error that doesn't seem easy to be solved:
[dcc32 Fatal Error] System.Console.pas(1213): F2084 Internal Error: URW1154

Tried cleaning and rebuilding the project. Not sure what we can do here.

from delphiconsole.

checkdigits commented on June 5, 2024 1

Het @JensBorrisholt if you need some help with getting hold of XE4 for this please let me know. I am an Embarcadero MVP and we're currently looking to add a bunch of things to GetIt - this unit being one of them. There are some things I can make happen for you via Embarcadero if you're going to maintain this repo going forward.

I don't have XE4 loaded but I can install it over the weekend and fix some of the problems if it helps you or I can reach out to some fellow MVPs and see if any of them have a XE4 installed.

Would you be open to the idea of us including DelphiConsole as one of the packages available via the GetIt package manager? It doesn't affect you directly - myself and some of the engineers at Embarcadero actually produce and co-ordinate the listings (as well as other MVPs and OSS maintainers) and we keep a watch on updates too so we can keep GetIt up to date,

Let me know what I can do to help.

-Ian.
DelphiConsole is a great addition - good work!

from delphiconsole.

checkdigits commented on June 5, 2024 1

Ah - I should have checked GetIt first!

I'll see what I can do over the weekend. It's possible that it can't be fixed for some versions of Delphi XE but those errors look like they would be fixable so we shall see if I can sort it out.

from delphiconsole.

checkdigits commented on June 5, 2024 1

OK - quick update. I tried downloading XE4 but I couldn't get it to activate for various reasons.

So the following is guesswork...

XE4 was the version which introduced changes to the ENDIF/IFEND conditional directive. So I'm wondering if that might be the problem?

If you edit the code so that IFEND is instead ENDIF as shown below this might resolve the issue for XE4 and below.

// XE4's CompilerVersion is 25
{$IF CompilerVersion <= 25}
const
  vkPeriod = $BE;
  vkPara =  $DF;
  vkOem102 =  $E2;
{$ENDIF}

from delphiconsole.

edwinyzh commented on June 5, 2024 1

@JensBorrisholt , tried again, I had to replace all occurrences of Int16.MaxValue.ToString into IntToStr(Int16.MaxValue), and the source seems to be valid on the syntax level, but then I got the following error which is the same mentioned days ago:
[dcc32 Fatal Error] System.Console.pas(1213): F2084 Internal Error: URW1154

That seems to be a compiler error which might related to the generics syntax, no idea how to solve it. Maybe @checkdigits can help :)

Update 1: PS: In the past I only met this 'Internal Error' issue (which couldn't be solved by restarting the IDE) only once with https://github.com/malcolmgroves/FluentQuery which intensively uses the generics feature.

from delphiconsole.

JensBorrisholt commented on June 5, 2024 1

I have now fixed the internal Error. I've tested with Delphi 2010.

The problem where TValue.From ... It have now been replaced.

Please update your code

from delphiconsole.