jensborrisholt/delphiconsole

The Console class from C# ported to Delphi

delphiconsole's Issues

Error

Delphi 10.2
demo under debug !!!!
system error 87
parameter is incorrect

procedure TPixel.SetPos(AxPos, AyPos: Integer);
var
OldVisible: Boolean;
begin
OldVisible := Visible;

try
Visible := False; <<<<<<< error

and took it off then game start and again
same error

Redirection not passible now

Nothing is written to a stream, instead everything is written to the console.

https://learn.microsoft.com/en-us/windows/console/writeconsole

The issue with this is that redirecting (app.exe > log.txt) DOESN't work...

I know C# has the same issue, but it breaks normal use where redirection is used like the standard Pascal Write/Writeln functions...

I'm currently looking into this because redirection is needed...

FixInsight warnings

Hi Jens,

I ran FixInsight over the System.Console unit and it reported a number of warnings. Would you accept a PR that fixes these?
I didn't take a look if they can all be fixed easily.

Here's the complete list:

[FixInsight Convention] System.Console.pas(932): C101 Method 'Console.MoveBufferArea' is too long (62 lines)
[FixInsight Convention] System.Console.pas(923): C102 Too many parameters in 'Console.MoveBufferArea' (9 parameters)
[FixInsight Convention] System.Console.pas(923): C103 Too many variables in 'Console.MoveBufferArea' (10 variables)
[FixInsight Convention] System.Console.pas(346): C104 Class name 'Console' should start with 'T'
[FixInsight Convention] System.Console.pas(348): C107 Class field name 'DefaultTextAttributes' should start with 'F'
[FixInsight Convention] System.Console.pas(351): C107 Class field name 'StdErr' should start with 'F'
[FixInsight Convention] System.Console.pas(352): C107 Class field name 'StdIn' should start with 'F'
[FixInsight Convention] System.Console.pas(353): C107 Class field name 'StdOut' should start with 'F'
[FixInsight Convention] System.Console.pas(354): C107 Class field name 'TextAttr' should start with 'F'
[FixInsight Warning] System.Console.pas(1001): W517 Variable 'StdIn' hides a class field, method or property
[FixInsight Warning] System.Console.pas(1168): W517 Variable 'ConsoleCursorInfo' hides a class field, method or property
[FixInsight Warning] System.Console.pas(996): W521 Return value of function 'Console.ReadKey' might be undefined
[FixInsight Warning] System.Console.pas(1352): W521 Return value of function 'Console.WriteString' might be undefined
[FixInsight Optimization] System.Console.pas(1023): O801 CONST missing for unmodified string parameter 'aCaller'
[FixInsight Optimization] System.Console.pas(1324): O801 CONST missing for unmodified string parameter 'aFontName'
[FixInsight Optimization] System.Console.pas(1352): O801 CONST missing for unmodified string parameter 'aValue'
[FixInsight Optimization] System.Console.pas(499): O804 Method parameter 'ALockObject' is declared but never used
[FixInsight Optimization] System.Console.pas(504): O804 Method parameter 'ALockObject' is declared but never used
[FixInsight Optimization] System.Console.pas(504): O804 Method parameter 'ATimeout' is declared but never used
[FixInsight Optimization] System.Console.pas(1046): O804 Method parameter 'Intercept' is declared but never used
[FixInsight Optimization] System.Console.pas(1349): O805 Inline marked routine 'Console.WriteString' comes after its call in the same unit

Question about GuiAndConsole

Whenever an application is compiled as a gui app, there is no problem to attach this application to to the parent console and send output to it.
But - and this effect is also visible in the GuiAndConsole demo - the parent console seems to have no idea that there was some text output and that the current cursor position and prompt should be e.g. 5 or 500 lines further down.

If you run GuiAndConsole and press Enter when done, the dos prompt shows up in the middle of the text that was output in the console window by the demo.
Do you have any idea how to tell the parent console where the prompt and cursor should be? Is this possible?

XE4 compilation error: System.Console.pas(83): E2003 Undeclared identifier: 'vkPeriod'

This is an excellent project, nothing like this in the Delphi community as far as I know.

Not sure what's the target compiler, but when compiling under xe4, I got the following error:
[dcc32 Error] System.Console.pas(83): E2003 Undeclared identifier: 'vkPeriod'

Would appreciate a fix :)