jeodc/descent3

Descent 3 by Outrage Entertainment -- Forked.

descent3's Issues

[Bug] Z-Ranges incorrect (effects visible through terrain)

Description

Increasing render distance via MAX_CELLS_TO_RENDER made a bug more visible. Z-ranges are incorrect for certain effects, causing them to be visible through terrain. Video below explains.

Descent.3.-.RenderDistance.Z-Wall.Bug.mp4

Regression Status

There is no regression--this appears to have always been around, but it is not present at the lowest render depth setting due to culling.

Steps to Reproduce

Tested with Level 7 - follow the guidebot to the first objective to disable the turrets, which will cause the blue electricity effects to appear.

[Feature] Custom models/ship properties implementation

Description

This issue is really to document things. The Descent 3 Pyromania mod replaces the vanilla ship selection with custom models, each with their own properties, and has some other features like new titlescreen artwork, classic weapons and sounds, and its own gamemode (.d3m).

The mod was created via hex editing the executable (pre-source release) and the relevant files mania15.hog and track.hog contain .gam files that replace the original game's Table.gam and extra.gam files (found in d3.hog and merc.hog). There is currently no method to append table files, so to use Pyromania, one must outright replace existing ships. In the future, it would be nice to be able to implement addons such as this via appending table files and optionally selecting which parts to use (as in this one, the Telcom ship selection menu would not provide the full array of ships if appended). If successfully done, multiplayer would need some kind of check for modded ships which a client may not have models of.

*Note: The custom/graphics and custom/sounds folders are used for ship decals and multiplayer taunts--NOT for mods as might be believed.

[Cleanup] mprintf statements are missing \n

Description

This is a good first issue for anyone with reservations to programming. Below is a sample of a d3.log file:

BEGINNING LOG

WinNT system.
FindArg: Did not find [-lowmem] on command line.FindArg: Did not find [-superlowmem] on command line.FindArg: Did not find [-dedicated] on command line.System Memory Status:
Percent of memory in use: 30
Bytes of physical memory : 2147483647
Free physical memory bytes  : 2147483647
Available virtual memory : -1
FindArg: Did not find [-himem] on command line.FindArg: Did not find [-nomultibmp] on command line.FindArg: Did not find [-limitframe] on command line.FindArg: Did not find [-dedicated] on command line.FindArg: Did not find [-framecap] on command line.Using default framecap of 60
FindArg: Did not find [-mlooksens] on command line.FindArg: Did not find [-mousesens] on command line.FindArg: Did not find [+host] on command line.FindArg: Did not find [-useport] on command line.FindArg: Did not find [-pxoport] on command line.FindArg: Did not find [-setdir] on command line.FindArg: Did not find [-useexedir] on command line.FindArg: Found [-windowed] at argument index (1).FindArg: Did not find [-lorestimer] on command line.FindArg: Did not find [-alternatejoy] on command line.FindArg: Did not find [-directinput] on command line.DDIO system initializing...
DI system initializing.
Timer: Hi-Resolution Timer available
Timer system initialized.
Keyboard initialized.
FindArg: Did not find [-vsync] on command line.FindArg: Did not find [-Width] on command line.FindArg: Did not find [-Height] on command line.FindArg: Did not find [-nomotionblur] on command line.FindArg: Did not find [-nosparkles] on command line.Setting up temp directory
FindArg: Did not find [-tempdir] on command line.Temp Directory Set To: "S:\Descent 3\custom\cache"
Lock file created in temp dir
Removing any temp files left over from last execution
FindArg: Did not find [-filter] on command line.FindArg: Did not find [-oldmethod] on command line.Network is down...
table filename = Table.gam
FindArg: Did not find [-mission] on command line.OSIRIS: Initializing module manager
OSIRIS: Extracting Scripts From Hog
Search started
Done Extracting
OSIRIS: Extracting Scripts From Hog
Search started
	Found: AIGame.dll...Extracting...Done
Done Extracting
OSIRIS: Extracting Scripts From Hog
Search started
	Found: AIGame.dll...Extracting...Done
	Found: CanyonsCTF.dll...Extracting...Done
Done Extracting
OSIRIS: Extracting Scripts From Hog
Search started
	Found: AIGame.dll...Extracting...Done
	Found: clutter.dll...Extracting...Done
	Found: generic.dll...Extracting...Done
	Found: HalfPipe.dll...Extracting...Done
	Found: InfernalBolt.dll...Extracting...Done
	Found: Paranoia.dll...Extracting...Done
	Found: Polaris.dll...Extracting...Done
	Found: Quadsomniac.dll...Extracting...Done
Done Extracting
895 strings loaded from the string tables
Initializing texture system.
Font <briefing.fnt> height = 10
Font <bbriefing.fnt> height = 18
Font <newmenu.fnt> height = 19
Font <smallui.fnt> height = 11
Font <largeui.fnt> height = 18
Font <lohud.fnt> height = 10
Initting dynamic lighting.
Building specular tables.
In InitMission()
FindArg: Did not find [-nonetwork] on command line.FindArg: Did not find [-netdebug] on command line.FindArg: Did not find [-useip] on command line.FindArg: Did not find [+ip] on command line.Application not started from a lobby.
Command line: "S:\Descent 3\Descent3.exe" -WINDOWED -LOGFILE

All of these are mprintf statements, for example...
https://github.com/DescentDevelopers/Descent3/blob/cffeb20a3e09d8c869134a465555374b7a9b40ae/Descent3/args.cpp#L74

Many of these statements do not have a \n at the end of their string, causing them to lump together. Sometimes this is intentional, like a continuation of a sentence. Other times, though, like below, it's just a difficult-to-read mess.

FindArg: Did not find [-himem] on command line.FindArg: Did not find [-nomultibmp] on command line.FindArg: Did not find [-limitframe] on command line.FindArg: Did not find [-dedicated] on command line.FindArg: Did not find [-framecap] on command line.Using default framecap of 60
FindArg: Did not find [-mlooksens] on command line.FindArg: Did not find [-mousesens] on command line.FindArg: Did not find [+host] on command line.FindArg: Did not find [-useport] on command line.FindArg: Did not find [-pxoport] on command line.FindArg: Did not find [-setdir] on command line.FindArg: Did not find [-useexedir] on command line.FindArg: Found [-windowed] at argument index (1).FindArg: Did not find [-lorestimer] on command line.FindArg: Did not find [-alternatejoy] on command line.FindArg: Did not find [-directinput] on command line.DDIO system initializing...

The unintentional lumps should be corrected by adding a \n to the end of the string like so:

mprintf((0, "GatherArgs: Arg (%d) is [%s].\n", q, GameArgs[q]));

This does not all need to be done in one sitting. There's a lot to sift through.