jesse1412/bot1412

OSRS Related Discord bot.

BOT1412

OSRS Related Discord bot.

Installation

1. Clone/download the repository.
2. Install the required packages from requirements.txt (pip install -r requirements.txt).
3. Provide a discord token for the bot in discord_token.py (see https://discordpy.readthedocs.io/en/latest/discord.html).
4. Invite the bot to your server.
5. Run "main.py" (python main.py)

bot1412's Issues

Update README

This would add more polish to the project, you could include:

• A brief description of the bot

• The technologies involved (language, packages used, etc.)

• A list of the commands available and a very short description of what they do with an outsider (non runescape-player) perspective in mind

• A short video demonstration showing some of the available features

Make the bot server agnostic.

Currently the bot assumes it's used on a single server. Things like the !roles and !debt commands are not designed with multiple servers in mind, changing that would be ideal.

Drop table corrections

Some boss drop tables have multiple tables (representing multiple rolls) within them when they perhaps should not, I am not fully certain of the correct implementation, however I thought this was worth pointing out due to your comments within drop_simulation.py namely:

# One monster's "drop table" often consists of multiple different tables. To be statistically correct, we must treat them separately if they can roll simultaneously.

Consider writing tests

Having the option to run test suites on newly developed code would really help in giving this project a professional touch, if this is something that is relevant for this project!

Add Chambers of Xeric drop simulation.

Add a way to simulate CoX completions, preferably by allowing people to specify number of points per raid and such.

Refactor discord_commands/drop_simulations.py

Currently this code is very messy (usage of identifiers such as extraArg1, which don't even follow the project name scheme). The entire thing should be refactored.

Add an installation guide for development purposes

A guide on how to install this project on a local machine would add a bit of polish to the project as a whole, as well reducing the barrier to entry for those newer to python, the detail of the guide would be entirely at your disgression of course.

1/73 description in probability_flavour_text

The probability of speccing b0aty a 73 is not precisely 1/73, therefore this probability conditional should be either removed or corrected