Giter Site home page Giter Site logo

Comments (3)

bartelink avatar bartelink commented on May 16, 2024

@sbose2k17 master now has a clearer implementation of the metrics events - there's one wart causing the extra logging config which I hope can be removed, see serilog/serilog#1124
I'm working on adding tests which will assert correct rery and logging behavior, which will, as a side-effect add extra items into the EventStore.Log.Events union, which will give us the info needed in a consistent fashion (as it happens, the withLoggedRetries mechanism already affords us a way to to it that is messy, but our wiring does not actually trigger it at the present time due to how we have wired up our retry policy)
cc @reuveniy

from equinox.

bartelink avatar bartelink commented on May 16, 2024

@sbose2k17 do we feel there still is a need to separate out this metric or should be close this for now?

I'm intending to revisit this soon wrt surfacing each attempt/load/retry as an xray span, but the basic mechanism wrt how we surface events/metrics will remain - so if the desire is to trap retries via events in the log stream, we may still have some work to do.

from equinox.

bartelink avatar bartelink commented on May 16, 2024

Closing on the assumption you'll reopen if/hen you need any more detail added to the presently exposed metrics

from equinox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.