jfoot/reading-buses-api

A C# .net Standard Library for the Reading Buses Open Data API

Linkdin Email Website Nuget Profile Google Play Microsoft Store Instagram

Hi there 👋

Welcome to my profile, I'm a software engineer at Experian and recent MSci in Computer Science graduate from the University of Nottingham.

I love developing, especially in C# and C++, some of my most popular projects include my live miniature departure board project for the Raspberry Pi, my Notts Hopper Buses android app, my Reading Buses nuget Library and a free educational program to teach and test the topic of Mathematical Transformations! I'm also a bit of a transport nerd, so have quite a few projects working with the Reading Buses API 🚌.

A full list of all my projects can be found on my website here

📄 Github Stats

reading-buses-api's Issues

Calling "GetStops()" on a BusService object does not differentiate between Bus Operators.

Reading-Buses-API/ReadingBusesAPI/BusServices/BusService.cs

Line 92 in 079adb6

private async Task<List<string>> GetStops()

Describe the bug
If you call the "GetStops()" function it will return back all the stops that any service of the same name has, regardless of the operator.

In instances where a service has the same ID between operators it will get all of the data.

To Reproduce
Call "GetStops()" on a service that is common between Reading Buses, Newbury and District and Kennections. An example would be service 4, which is used in both RB and in Kennections and causes issues.

Expected behaviour
It should only return the bus stops for the associated service, operator dependent.

Additional context
A fix has been established and has been implemented into a private project. The changes will be propagated into this project when time allows. If this is causing significant issues to anyone please let me know and I can try to priorities it's implementation.

Reading Buses API is being deprecated and upgraded.

Following an announcement from R2P group, the current Reading Buses API http://rtl2.ods-live.co.uk/cms/ is being shut down on the 6th of April 2021.

Being replaced by a new API feed found here: https://reading-opendata.r2p.com

It is unclear as of yet how much work will be required to get this library to work on the new API. But the current library will cease working from the 6th.

I will assess how much work is needed to update the library once released.