jhandley/picocom

Fork of picocom that implements line edit, history command completion for send/receive file.

picocom's Issues

Potential buffer overrun in function init_send_receive_history

In your code, in picocom.c, line 676, you should use "strcpy" instead of "strcat".
As you get "send_receive_history_file_path" from a "malloc", there is no guarantee that it will be zeroed-out.
This, or you should change "malloc" to "calloc".

https://github.com/jhandley/picocom/blob/master/picocom.c#L676

Merged your improvement to original picocom

Hi,

I'm the original author of picocom.

Someone tipped me about your fork. Having line-editing and path-completion support when entering filenames for send- and receive- file operations is indeed very neat! Furthermore the linenoise library has adequately small footprint to affect only minimally the "pico" character of picocom.

So, I have merged your additions / improvements to the original picocom with a couple of very minor tweaks: I made the linenoise support optional (you can compile it out by commenting-out a couple of lines in the Makefile). I changed the way C-c is handled when entering a filename (the transfer operation is canceled, instead of exiting picocom). I fixed a potential bug in init_send_receive_history() (I'll file a separate issue for this). And... that's all.

I hope you don't mind.

It would be great if you could take a look at my merge and see if I have fucked-up something obvious...

The code can be checked out from the SVN trunk by:

  svn http://picocom.googlecode.com/svn/trunk/ ./picocom

Soon I will stamp-out a new release (1.8) with the new features.

Thanks for helping improve picocom!

Cheers
/npat