jherr/no-bs-ts

No BS TS (Typescript) example code

no-bs-ts's Issues

Issues with Property 'children'

I am facing some issue with regards to the props type for children.
Looked up in StackOverflow but I am still not sure how to resolve it.

Issues with conditionals.ts

I have installed node-fetch dependency. However, the conditionals.ts has an error

Argument of type 'unknown' is not assignable to parameter of type 'PokemonResults'.ts(2345)

The data.json response from the fetch function returns Promise<unknown> type

Fix is to cast data to `Promise

fetch(url)
      .then((data) => data.json() as Promise<PokemonResults>)
      .then((data) => cb(data));

There is also error with fetch.

ts conditionals.ts
Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/tonis/workspace/web/ti-no-bs-ts/ts-basics/node_modules/node-fetch/src/index.js from /Users/tonis/workspace/web/ti-no-bs-ts/ts-basics/conditionals.ts not supported.
Instead change the require of index.js in /Users/tonis/workspace/web/ti-no-bs-ts/ts-basics/conditionals.ts to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/Users/tonis/workspace/web/ti-no-bs-ts/ts-basics/conditionals.ts:15:38)
    at Module.m._compile (/Users/tonis/workspace/web/ti-no-bs-ts/ts-basics/node_modules/ts-node/dist/index.js:735:29)
    at Object.require.extensions.<computed> [as .ts] (/Users/tonis/workspace/web/ti-no-bs-ts/ts-basics/node_modules/ts-node/dist/index.js:737:16)
    at main (/Users/tonis/workspace/web/ti-no-bs-ts/ts-basics/node_modules/ts-node/dist/bin.js:238:16)
    at Object.<anonymous> (/Users/tonis/workspace/web/ti-no-bs-ts/ts-basics/node_modules/ts-node/dist/bin.js:351:5) {
  code: 'ERR_REQUIRE_ESM'
}

The solution is to downgrade fetch to v2. link. yarn add node-fetch adds v3 automatically

Duplicate function implementation

no-bs-ts/series-1/episode-11/enums.ts

Line 30 in 9bd14de

function sendEvent(name: "addToCart", data: { productId: number }): void;

Now getting a "Duplicate function implementation" error in TS 4.9+

Redundant setValue

It seems that the setValue in line-32 is redundant. Since the useEffect is adding a subscriber.

no-bs-ts/series-2/episode-2-pubsub/state-manager/src/simpleStateManager.ts

Lines 25 to 35 in 82dd719

	const [value, setValue] = useState<DataType>(initialValue);
	useEffect(() => subscribers.subscribe(setValue), []);
	return [
	value,
	(v: DataType) => {
	setValue(v);
	subscribers.publish(v);
	},
	];

Many thanks for the great content on YouTube!