jiangts/js-otp

100% Javascript Implementation of HOTP and TOTP for Two-Factor Authentication.

js-otp's Issues

Lack of credits/licence in jsOTP.js

Hi,

jsOTP.js Lack of credits and licence infos.

I added this in the file I use, inspired from jsOTP.min.js:

--- a/jsOTP.js
+++ b/jsOTP.js
@@ -1,3 +1,11 @@
+/*
+* File combining
+* (1) sha.js by Brian Turek 2008-2013 under BSD license
+* (2) and a modified js OTP implementation found on JSFiddle
+*
+* See https://github.com/jiangts/JS-OTP for more information
+*/
+
 (function() {
   var Hotp, Totp;
 

Failure to generate hotp with counter > 127

Hello,

Nice javascript. I receive an error when generating an hotp with a counter size > 127.

hotp.getOtp(secret,128) will fail: my console shows the following output:

URIError: malformed URI sequence
line 85 in Hotp.prototype.uintToString

Bad totp length for tokens over 6 characters long

For secret TCFBROLCJDXLCDQQY63MAOX6HXZPKR335YPAVAMADXAQ2PF2MBB7FQV2BT5Z5PWM and timestamp 1525821908, totp length 8, the generated totp is 1. Should be 01680911.

Base64 implementation is broken

The implementation for Base64ToHex in this project is broken for Base64 strings that do not amount to a multiply of eight.

Replacing base32tohex in jsOTP.js fixes those issues:

base32tohex(base32) {

            let base32chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ234567";
            let bits = [];

            for (let i = 0; i < base32.length; i++) {
                let intVal = base32chars.indexOf(base32.charAt(i).toUpperCase());

                if (intVal === -1 || intVal === null) {
                    throw new Error("Invalid B64 char: " + base32.charAt(i));
                }

                let binaryRep = intVal.toString(2);
                let diffLen = 5 - binaryRep.length;

                for (let j = 0; j < diffLen; j++) {
                    bits.push("0");
                }

                for (let j = 0; j < binaryRep.length; j++) {
                    bits.push(binaryRep[j]);
                }
            }

            let hexstr = "";
            for (let i = 0; i < bits.length; i += 8) {
                let binByte = bits.slice(i, i + 8).join("");
                if (binByte.length < 8) {
                    continue;
                }
                let hexn = parseInt(binByte, 2).toString(16);

                hexstr += hexn.length === 2 ? hexn : "0" + hexn;
            }


            return hexstr;
}

No license specified

There's no code license, which means it's copyright infringement to actually use this library.

Can I have the test code for the RFC's test vector?

https://tools.ietf.org/html/rfc6238

Thanks.

Current build process generates .js files in es6 but uglifyjs version used doesn't understand es6

>> Uglifying source dist/jsOTP.js failed.
Warning: Uglification failed.
Unexpected token: name (Totp).
Line 4 in dist/jsOTP.js

Line 4 is:

Totp = class Totp

Having issue with Mega.nz totp generation

Hi, I'm trying to generate totp for mega.nz account which have 52 character secret. Google authenticator giving totp fine. But this js not working.
Can you look into it.