jiayisoftware/jiayilauncher

Minecraft for Windows mod manager

jiayilauncher's Issues

Proposal: Consider using Appx Packages

This would have many advantages:

• Easy installation
• Easy to uninstall
• Follows the overall standard of a Windows application
• Allows to reset app data from settings (and cache, ...)
• File extension can be specified in package manifest
• Easy for other apps to find the program on your system

Edit:

• You can (or need to) sign the appx package, this would allow people verify that the package is legit
• (Microsoft Store!?)

Offline mode is enabled while internet connection is fine

everytime i launch the application as admin it says im offline but my wifi is on and great. what is happening?

when i have this speed of wifi

Un-fuck drop down boxes

the code is a mess, so let's fix it

Launcher randomly crashes after opening

The Toasts Room

general discussion for how to implement toasts. even if you're not a developer, you can throw in your two cents on how they should look and behave

very deep crash when trying to switch versions

log for reference:

[...]
[18:55:36] [VersionManager - Info]: Switching to version 1.18.12.1
[18:55:36] [TargetInvocationException - Error]: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> System.InvalidCastException: Specified cast is not valid.
   at System.Runtime.InteropServices.Marshal.ThrowExceptionForHR(Int32 errorCode)
   at WinRT.IObjectReference.As[T](Guid iid)
   at WinRT.IObjectReference.As[T]()
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
   --- End of inner exception stack trace ---
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
   at WinRT.SingleInterfaceOptimizedObject..ctor(Type type, IObjectReference objRef, Boolean requireQI)
   at WinRT.SingleInterfaceOptimizedObject..ctor(Type type, IObjectReference objRef)
   at Windows.Storage.ApplicationData.Make__lazy_global__System_IDisposable()
   at Windows.Storage.ApplicationData.AsInternal(InterfaceTag`1 _)
   at Windows.Storage.ApplicationData.Dispose()
   at JiayiLauncher.Features.Versions.VersionManager.Switch(String version) in D:\projects\JiayiLauncher\JiayiLauncher\Features\Versions\VersionManager.cs:line 135
   at JiayiLauncher.Pages.Extra.FullVersionList.SwitchClicked(String ver) in D:\projects\JiayiLauncher\JiayiLauncher\Pages\Extra\FullVersionList.razor:line 215
   at JiayiLauncher.Pages.Extra.FullVersionList.<>c__DisplayClass0_0.<<BuildRenderTree>b__6>d.MoveNext() in D:\projects\JiayiLauncher\JiayiLauncher\Pages\Extra\FullVersionList.razor:line 67
[...]

i think it's an issue with winrt because of how deep this stack trace is but i could be wrong

Create a contributor/code style guide

how to build and publish, code style, naming conventions, stuff like that

IMPORTANT: HURRY!

my friends and parents all left after i instlaled jiayi please help

Make long actions more apparent in profiles

examples being creating and applying profiles

Error code 0x80040403 thrown when trying to get update tokens

this has been a known issue for a very long time and i have no idea how to fix it
only some people have been getting this error which only adds fuel to the fire

Allow dragging folders and links to add them to a mod collection

folders and links aren't implemented yet because of limitations, let's fix

[Injector - Error]: Every native call succeeded, but the module wasn't loaded.

I tried to launch latite client dll with Jiayi launcher, but it does not work. It does work if I inject it with fate injector.
It still doesn't work after disabling Windows Defender (my only antivirus).
it was like this even before the 1.21 update, just did not think of opening an issue back then.

Log:

[12:05:34] [Launcher - Info]: Launching Latite
[12:05:34] [Minecraft - Info]: Current game version is 1.21.3.0 and mod supports Any version
[12:05:35] [Launcher - Info]: Opened game, waiting to launch mod...
[12:05:38] [Discord - Info]: Presence updated: 正在玩 no mods - 在 1.21.3.0
[12:05:43] [Discord - Info]: Presence updated: 正在玩 no mods - 在 1.21.3.0
[12:05:43] [Launcher - Info]: Detected internal mod
[12:05:43] [Injector - Info]: Injecting C:\Users\User\AppData\Local\JiayiLauncher\Mods\Latite.dll
[12:05:44] [Injector - Error]: Every native call succeeded, but the module wasn't loaded.

Full log

Jiayi Launcher

Fate Injector

Launcher crash when downloading version (so far 1.18.31, which had no error but straight up just closed the launcher, 1.19.71 and 1.19.73 are the ones that don't seem to work, though I havent tried anything else.)

[16:49:18] [JiayiSettings - Info]: Loaded settings.
[16:49:18] [ModCollection - Info]: Loaded mod collection at C:\Users\dpr39\AppData\Local\JiayiLauncher\Mods
[16:49:19] [JiayiSettings - Info]: Saved settings.
[16:49:19] [ThemeManager - Info]: Applied theme.
[16:49:19] [JiayiStats - Info]: Loaded stats.
[16:49:19] [Discord - Info]: Connected to GoldenMeerket#8554
[16:49:20] [Discord - Info]: Presence updated: Playing with no mods - on 1.19.83.1
[16:49:32] [TargetInvocationException - Error]: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
---> System.Runtime.InteropServices.COMException (0x80040403): 0x80040403
at System.Runtime.InteropServices.Marshal.ThrowExceptionForHR(Int32 errorCode)
at JiayiLauncher.Features.Versions.RequestFactory.GetUpdateToken() in D:\projects\JiayiLauncher\JiayiLauncher\Features\Versions\RequestFactory.cs:line 46
at JiayiLauncher.Features.Versions.RequestFactory.BuildUpdateTickets() in D:\projects\JiayiLauncher\JiayiLauncher\Features\Versions\RequestFactory.cs:line 64
at JiayiLauncher.Features.Versions.RequestFactory.BuildHeader(String url, String methodName) in D:\projects\JiayiLauncher\JiayiLauncher\Features\Versions\RequestFactory.cs:line 78
at JiayiLauncher.Features.Versions.RequestFactory.GetDownloadUrl(String updateId) in D:\projects\JiayiLauncher\JiayiLauncher\Features\Versions\RequestFactory.cs:line 99
at JiayiLauncher.Features.Versions.VersionManager.DownloadVersion(MinecraftVersion version) in D:\projects\JiayiLauncher\JiayiLauncher\Features\Versions\VersionManager.cs:line 39
at JiayiLauncher.Pages.Extra.FullVersionList.DownloadClicked(MinecraftVersion ver) in D:\projects\JiayiLauncher\JiayiLauncher\Pages\Extra\FullVersionList.razor:line 151
at JiayiLauncher.Pages.Extra.FullVersionList.<>c__DisplayClass0_0.<b__8>d.MoveNext() in D:\projects\JiayiLauncher\JiayiLauncher\Pages\Extra\FullVersionList.razor:line 73
--- End of stack trace from previous location ---
at Microsoft.AspNetCore.Components.ComponentBase.CallStateHasChangedOnAsyncCompletion(Task task)
at Microsoft.AspNetCore.Components.RenderTree.Renderer.GetErrorHandledTask(Task taskToHandle, ComponentState owningComponentState)
at Microsoft.AspNetCore.Components.WebView.Wpf.WpfDispatcher.InvokeAsync(Action workItem)
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
--- End of inner exception stack trace ---
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
at System.Delegate.DynamicInvokeImpl(Object[] args)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
at System.Windows.Threading.DispatcherOperation.InvokeImpl()
at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(Object obj)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at MS.Internal.CulturePreservingExecutionContext.Run(CulturePreservingExecutionContext executionContext, ContextCallback callback, Object state)
at System.Windows.Threading.DispatcherOperation.Invoke()
at System.Windows.Threading.Dispatcher.ProcessQueue()
at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
at System.Windows.Application.RunDispatcher(Object ignore)
at System.Windows.Application.RunInternal(Window window)
at JiayiLauncher.App.Main()

Timeout while downloading from jiyayi.mcpeplayground.com. Also Profram doesn't do anything.

Prety Obvius Fixes:

1. Use Github Actions ( free for public repos ).
2. Use a normal DDL site like Mediafire.

Theme backgrounds fail to load when there are multiple themes

Cant load the theme's background img when you have multiple themes

heres my wwwroot folder, for test
all themes are in \wwwroot\themes\.local
wwwroot.zip

Launcher starts and closes almost instantly

.NET was installed by the Jiayi installer ;
I click the start menu shortcut and the Launcher window appears and disappears almost instantly.
taskkill reveals no process like JiayiLauncher.exe is up