jibanprakash/khoj

Khoj - The Search Engine

This is Khoj - The multi-platform Local search engine

Copyright (C) 2014 Jiban Prakash, jibanprakash.jp(at)gmail(dot)com Saurabh Araiyer, sizzsa(at)gmail(dot)com

This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or any later version.

This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.

You should have received a copy of the GNU General Public License along with this program. If not, see http://www.gnu.org/licenses/.

khoj

Khoj - The Search Engine

khoj's Issues

Integer Overflow for files >= 2GB

There's an integer overflow problem in lookupFile.cpp

If you look at lines 45 & 46:

while (getline(inputFile, line)
fileList.push_back(line);

\n characters are scanned and then line content gets added to fileList list.Next, there is a loop at line no 60:

for(int i = 0; i < (int)fileList.size(); i++)

We can see, a signed integer variable i is being used for loop counter which goes till the total number of lines scanned with the earlier code, however if there are \n characters more than 2147483647 (INT_MAX for a signed integer) then the loop will overrun after the truncation occurs and will produce invalid results.

So, at minimum a file having 2147483648 \n newline characters should overflow the signed integer variable.Resulting file min. filesize will be - 2147483648/1024/1024/1024 = 2 GB

• Prakhar Prasad

Issue cc: @saurabhsar