jimjbrettj/etc-reference-letter

etc-reference-letter's Issues

Heroku Deploy Issues

Below are the heroku logs I get from when I try to deploy the Typescript app to Heroku. The client React app located at the root, compiles and runs locally at localhost:3000.

The Node.js app is in /api folder and the package.json seems to be configured correctly as once again, when running locally it correctly grabs the build folder resulting from running npm run build on the React app.

I was thinking that maybe an easier deployment strategy would simply be separate repositories. There seems to be some kind of dependency mismatch with when heroku is trying to build.

2020-04-20T22:55:57.940591+00:00 app[web.1]: > [email protected] start /app
2020-04-20T22:55:57.940592+00:00 app[web.1]: > react-scripts start
2020-04-20T22:55:57.940592+00:00 app[web.1]:
2020-04-20T22:56:00.783624+00:00 heroku[web.1]: State changed from starting to up
2020-04-20T22:56:00.616896+00:00 app[web.1]: ℹ ｢wds｣: Project is running at http://172.16.178.166/
2020-04-20T22:56:00.617383+00:00 app[web.1]: ℹ ｢wds｣: webpack output is served from
2020-04-20T22:56:00.617464+00:00 app[web.1]: ℹ ｢wds｣: Content not from webpack is served from /app/public
2020-04-20T22:56:00.617563+00:00 app[web.1]: ℹ ｢wds｣: 404s will fallback to /
2020-04-20T22:56:00.617780+00:00 app[web.1]: Starting the development server...
2020-04-20T22:56:00.617781+00:00 app[web.1]:
2020-04-20T22:56:29.930428+00:00 app[web.1]: Failed to compile.
2020-04-20T22:56:29.930437+00:00 app[web.1]:
2020-04-20T22:56:29.930912+00:00 app[web.1]: /app/src/App.tsx
2020-04-20T22:56:29.930914+00:00 app[web.1]: TypeScript error in /app/src/App.tsx(5,19):
2020-04-20T22:56:29.930915+00:00 app[web.1]: Could not find a declaration file for module 'react'. '/app/node_modules/react/index.js' implicitly has an 'any' type.
2020-04-20T22:56:29.930917+00:00 app[web.1]: Try `npm install @types/react` if it exists or add a new declaration (.d.ts) file containing `declare module 'react';`  TS7016
2020-04-20T22:56:29.930917+00:00 app[web.1]:
2020-04-20T22:56:29.930918+00:00 app[web.1]: 3 | import { TutorialToken } from "./contract-types/TutorialToken"; // import is correct
2020-04-20T22:56:29.930918+00:00 app[web.1]: 4 | import { readFileSync } from "fs";
2020-04-20T22:56:29.930919+00:00 app[web.1]: > 5 | import React from 'react';
2020-04-20T22:56:29.930919+00:00 app[web.1]: |                   ^
2020-04-20T22:56:29.930919+00:00 app[web.1]: 6 | import * as ReactDOM from 'react-dom';
2020-04-20T22:56:29.930920+00:00 app[web.1]: 7 | import TutorialTokenAbi from './contract-data/TutorialToken.json';
2020-04-20T22:56:29.930921+00:00 app[web.1]: 8 | import Writer from './components/writer/Writer';
2020-04-20T23:28:59.988715+00:00 heroku[web.1]: Idling
2020-04-20T23:28:59.993200+00:00 heroku[web.1]: State changed from up to down