jimparis/jimicon

jimicon's Issues

hiding imagecreatefromstring() warning

UPDATE: oops, looks like GD simply ignores any error_reporting control whatsoever, so just ignore the below. sorry for the noise.

sorry it's not a PR. as I was testing php8, I ran into jimIcon generating stubborn GD warnings at line 107, it seems that @ is already there but either GD or PHP ignores it. this ugly blob was the best I could do to hide it:

diff --git a/lib/jimIcon.php b/lib/jimIcon.php
index d976c808b..29ae8df1d 100644
--- a/lib/jimIcon.php
+++ b/lib/jimIcon.php
@@ -103,8 +103,12 @@ class jimIcon {
                         return false;
                 }

-                // See if we can parse it (might be PNG format here)
-                $i = @imagecreatefromstring($data);
+                                        // See if we can parse it (might be PNG format here)
+                                        $er = error_reporting();
+                                        error_reporting(0);
+                                        $i = imagecreatefromstring($data);
+                                        error_reporting($er);
                 if ($i) {
                         imagesavealpha($i, true);
                         return $i;

not sure if there's any better way, mentioning it here so this won't get reintroduced at some time later.