jj101k/celery

A lightweight PHP Slim-like PSR-7 framework

celery's Issues

Nested file input is not parsed correctly

$_FILES:

Array
(
    [bar] => Array
        (
            [name] => Array
                (
                    [baz] => Array
                        (
                            [0] => 
                        )

                )

            [type] => Array
                (
                    [baz] => Array
                        (
                            [0] => 
                        )

                )

            [tmp_name] => Array
                (
                    [baz] => Array
                        (
                            [0] => 
                        )

                )

            [error] => Array
                (
                    [baz] => Array
                        (
                            [0] => 4
                        )

                )

            [size] => Array
                (
                    [baz] => Array
                        (
                            [0] => 0
                        )

                )

        )

)

getUploadedFiles():

Array
(
    [bar] => Celery\UploadedFile Object
        ...GARBAGE...

Bodies should stream

It was always intended that bodies would stream.

They do not.

Oops.

Sample script producing different behaviour on Slim and Celery

$ php test/sample.php Celery\\App; echo
[]
$ php test/sample.php Slim\\App; echo
{"type":"notallowed","methods":["GET"]}
$ 

Oops

Regression: tests failing

PHPUnit 7.5.9 by Sebastian Bergmann and contributors.

..........FFFF.                                                   15 / 15 (100%)

Time: 113 ms, Memory: 4.00 MB

There were 4 failures:

1) AppTest::testHandlers
GET /a: as expected
Failed asserting that null is identical to Array &0 (
    'method' => 'any'
    'args' => Array &1 ()
).

/Users/jimdriscoll/Public/celery/test/04-appTest.php:93

2) AppTest::testHelloWorld
Simple body worked as expected
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'Hello world'
+'Not found'

/Users/jimdriscoll/Public/celery/test/04-appTest.php:168

3) AppTest::testConfig
errorHandler: works
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
-    'type' => 'exception'
+    'type' => 'notfound'
 )

/Users/jimdriscoll/Public/celery/test/04-appTest.php:254

4) AppTest::testNoConfig
errorHandler (default): produces 500 error
Failed asserting that 'HTTP/1.1 404 Not Found' matches PCRE pattern "#^HTTP/1.1 500#".

/Users/jimdriscoll/Public/celery/test/04-appTest.php:330

FAILURES!
Tests: 15, Assertions: 48, Failures: 4.

ServerRequest#getParsedBody() is always empty

Not sure how this happened, but there is nothing that uses withParsedBody() and nothing which assigns to its backing store.