jjallaire/draftpod

Draft simulator for Magic the Gathering

draftpod's Issues

add note on fullscreen mode to docs

add privacy policy

e.g.
https://scryfall.com/docs/privacy
https://draftsim.com/privacy

confirm that simulator still works correctly

bot color commit may have busted it: 3dfac4b

layout changes for mobile devices

Now that we are specifying that the site is responsive on mobile devices (4378f90) we need to update our bootstrap html for the home and guide pages to behave properly on phones.

consider converting multi-player drafts to single-player if they aren't found in firestore

complete initial documentation

Still need to write a bit more about creating custom cubes

use alternate versions of mana icons

find more storage efficient way to display bot colors

We used to clear out all of the pick piles (at least when not running under the simulator) however changed this in order to able to show bot colors:

f19bfb7

It seems like we should be able to just compute the bot colors once and just store that.

make it easier to copy draft URL on iOS

Copy button currently doesn't work.

article on draft bot behavior

Used as a roadmap to others that want to work on improving the bots

show pack passing direction in table view

Passing to the left for packs 1,3, right for pack 2

provide some right padding for mana colors legend

evaluate optimistic local commits

When we have sketchy connectivity and allow multiple pick transactions to be in flight at once we might be opening ourselves up to inconsistency (as the first transaction could fail and roll back, whereas subsequent transactions succeed).

We may need a more conservative model visa-vi the optimistic local writes of picks. Perhaps we actually need to put glass on the UI until the transaction completes? (with a suitable progress indicator).

evaluate whether we need picks_complete global flag

Can result in a player being stuck in deckbuilding (due to picks_complete: true but without their cards being moved into their deck.

export drafts in mtgo draft log format

Provide default name for custom cardpools

archive drafts pick data for offline analysis

Dump into BigQuery?

support for importing from deckbox

It would be great to be able to import from Deckbox as well as Decked Builder. From what I can see the standard CSV export from Deckbox has the info we need to match up to Scryfall data:

We will need the "Count", "Edition", and "Card Number" fields to do the import. I'll polk around a bit to see if anything in our current code needs to change significantly to accommodate this.

investigate client disconnected errors we saw in local mode

When starting a local draft on 1/20/19, we saw both Chrome and Firefox issue what it seemed like spurious client disconnected errors. We've disabled this validation for now pending investigation (004e23d) so that users aren't disrupted.

consider managing firebase config in a separate repository

Handle Split/Transform cards in preview (.card-viewer)

For non-mobile: can we elegantly identify split/multi-faced cards from:

1. Scryfall (card-faces array=populated, card_faces.image_uris[] not set indicating split, set indicating transform)
2. MTGJSON (card.layout = 'transform' or 'split'). If so, we can rotate the split cards and display both faces for transform cards. The former will save some head turning for those who don't have the card text memorized.

Trigger for the onMouseOver would need updating.

We would need to set the transform, transform-origin, and margin-left properties programatically. The below achieved the proper orientation for regular split cards.

<div class="card-viewer" style="transform: rotate(90deg); transform-origin: left top; margin-left: 100%;"><img src="https://img.scryfall.com/cards/normal/front/8/f/8f1801f2-ea6e-4196-858e-2afc456cf6a0.jpg?1538879984"></div>

Note, this may result in some overlap in the pick area, but retains the placement of the stats info box.

Planar cards (from planechase) would require rotation handling, but nobody's going to be drafting those. Other card types should not require special handling. Meld could be handled just like transform.

For Mobile: Don't bother rotating splits. Layouts need working on for phones/tablets for the base cases first, then review to see about mods for double faced cards.

add note on open source contributions to welcome page

Add LICENSE file to top-level of repo

don't sync from firestore after draft is complete

Would allow us to archive old multiplayer drafts once they are completed

should updateTable reject the promise on failure

Need to see which clients actually subscribe to the promise.

Currently, NavigatorStart.startDraft doesn't listen to the promise resolution and as a result can create a draft that can never be joined (b/c the packs aren't distributed).

Perhaps the solution to unjoinability is to just filter out drafts that have current_pack === 0 from the list (or even drafts with no start time)

add article on bot behavior to faq

use remote images by default

So that development configurations work by default.

We should add another environment variable that turns on local images.

authenticate with firebase only on demand

add Ixalan and Rivals of Ixalan sets

configure travis.ci to run our tests on every commit

code to periodically purge multiplayer draft table state

user discussion forum

If we don't open-source the repo, we still need some way to have dialog w/ users about bugs, features, etc.

use more capable localStorage backend

We've had QuotaExceededError for some clients using localStorage. Look at swapping in localForage with indexedDB.

don't require special "join" URL

try to handle in the router

Create README.md for the project

Include references/links to other open-source projects we depend on.

audit use of new Promise to ensure we are using the most clean/compact promise semantics

second pack contents shifts after first pick

Sometimes in multiplayer mode the second pack comes in and then blinks out (with one card being different). This can be repro'd with only a single-player at the table.

Investigate why this occurs.

a bit more descriptive text on the home page above the screenshot.

article on setting up a development configuration

create cloud function for cleaning up multi-player drafts

https://firebase.googleblog.com/2017/03/how-to-schedule-cron-jobs-with-cloud.html

revise screenshots that show set and mana icons

automated integration tests

At a minimum we should setup automated tests that run through several drafts end-to-end (single and multi-player ideally).

present deck colors in consistent order

e.g. always BG rather than sometimes BG and sometimes GB

remove older sets (MM13, Innistrad) entirely until we get permission to use the rankings

show split cards horizontally on touch press

multiplayer drafts should be able to survive failure to sync to firestore

That will allow us to archive old multiplayer drafts.

log into firebase only on demand

Need to sort out how to chain the various promises together and still get errors reported.

improve look of info links at the bottom of pages

more compact serialization of drafts into local storage

Use same technique as we do for firestore

Auto generate set specific data/classes from external data source

Looking at the sets-xxx.js, it seems this should be able to be generated on the fly and not require hard coding. The main point seems to generate the booster pack content. Scryfall doesn’t offer this data but this site does:

docs.magicthegathering.io

There is a JS api for this site: mtg-sdk-javascript

{ "set":{ "code":"KTK", "name":"Khans of Tarkir", "type":"expansion", "border":"black", "mkm_id":1495, "booster":[ [ "rare", "mythic rare" ], "uncommon", "uncommon", "uncommon", "common", "common", "common", "common", "common", "common", "common", "common", "common", "common", "land", "marketing" ], "mkm_name":"Khans of Tarkir", "releaseDate":"2014-09-26", "magicCardsInfoCode":"ktk", "block":"Khans of Tarkir" } }

This should be readily parsed into the existing data forms.

Should this be persisted in our firebase store, or just st generated on first call? The overhead should be tiny thus storing might be overkill.