jjdeforrest/java-code-academy

java-code-academy

java-code-academy's Issues

Summary

Rubric Score

Criteria 1: Functionality

• Score Level: 3/4 (Meets Expectations)
• Comment(s): You did well implementing all of the core functionality in your code. I wasn't able to actually run the tests against your code however, since you didn't upload the testing file with your repo. Additionally, you gave your file the extension of ".java", which is incorrect. This is a JavaScript file and should be given the extension ".js". Despite similarity in name, Java and JavaScript are not the same language. Other than that, nice work!

Criteria 2: Formatting

• Score Level: 4/4 (Exceeds Expectations)
• Comment(s): Your code is properly indented and formatted according to the specification. Nice work!

Criteria 3: JavaScript Techniques

• Score Level: 3/4 (Meets Expectations)
• Comment(s): You did well using appropriate JS techniques in your code. You leveraged const/let where appropriate in most places and did well implementing method shorthand for each of the methods. I did notice that you used "var" in some locations. You should always be using either const/let for all variable declarations. You also did well using existing iterators if applicable. Nice work!

Overall Score: 10/12

Overall, you did a great job with this. Your code was formatted well and you utilized a lot of important JavaScript techniques. You also did well implementing the core functionality. Nice work!