jjppof/goldensun_html5

An online Golden Sun Engine entirely built in HTML5 with Phaser 2. Check https://gshtml5.org/

goldensun_html5's Issues

Set collision (create bodies) from tiledmap.

Keep avatar open while in dialog.

While using the DialogManager, the avatar keeps opening and closing between dialog windows. In the game, this avatar keeps open throughout the dialog.

World map

https://gamedev.stackexchange.com/questions/24957/doing-an-snes-mode-7-affine-transform-effect-in-pygame

Improve italic font chars position.

Some chars are not very well aligned:

Also, there's no single quote or comma. Better would be checking if those two chars are correct.

Pass MainChar.ts and Enemy.ts common attrs to Player.ts.

Teleport between places (without changing map).

Today, a TeleportEvent can only be made between maps. Would be nice if we could teleport between places on the same map with the same fading effects.

Migrate the system to use ControlManager/ CursorManager/ new Horizontal Window/ new ItemCounter/ new CharsMenu.

Shop transition bugs

Create a Summon class and a summon_list to avoid using summon_db.

Every time we need summon data, we access it directly from GoldenSun.dbs.summons_db. Even though it's working, would be nice to have a Summon class where its instances would be listed inside GoldenSun.info. In the future, when adding summons dynamically, this new Summon class will be helpful.

Build Battle Status Menu.

Growth

the E key only casts growth if Isaac has the psynergy

Screenshots in the README?

I think people will be more interested in testing this neat re-implementation and maybe collaborate with some code if you show the current state of this reimplementation in the README.

Add Yes/No animations used in shop

Fix psynergy aura z-index while casting move, for instance.

Create typescript enums (or something similar) for inline data.

Make an evaluation whether would be better to change this type of data:

to Typescript enums.

Check cache to avoid a double request for everything.

Even if we get a 30x response status as in this example when going from Madra to Madra Side:

would be nice if no request was made.

Smooth hero and npc direction turn when start talking.

When talking to a NPC, both hero and NPC immediately turn to the conversion direction. The direction should transit to the final one.

Low FPS at firefox

It seems that it's running slow on firefox.

Revive/Cure menu (healer menu).

Face wrong direction when dropping stairs

When releasing down arrow just after dropping stairs then pressing up arrow, the hero keeps going in the wrong direction.

Finish Djinn menu.

Remove current attr for atk, def, agi and luk.

Hi, jippof, please take a look

hi, jjppof, ( I do not know if you can see this message, if you could, please reply to me when you have a chance)

first, I would like to appreciate people like you to make this GS engine, although based on our Demo, there still plenty that we could do. A bit about me, I was one of the fan of our GS, and after played the GS Generation 3, I felt the story leftover so much to tell us. And personally, I enjoyed play gen 1st and 2nd much more then gen 3nd.
For me, the most fancinating part of GS is the mechanism of PSYCHIC AND DINJIN, I was always look for if there is a game like it, but so far, no luck. So I started to wondering if it is possible that we could do something to rebuild even partially of the GS ( Again, thanks for making the GS engine, it is amazing.)
I was currently working on Computer science degree on a 4-year school ( I did have some prior programming experience for c and c++, but very little for HTML5 and JavaScript)

so I download the HTML5 ( again, not so familiar with it), so I ran it, it gave a web address, when I loaded it in my Chrome, it gave me exactly same web page like the Demo.
With all my respect, Is that all we have currently? ( I know you are not going to make the animation or map, but is it possible for people who interested at this to make it by ourselves by making use of what you provided here? If so, where should we get started? Do we need to have some JavaScript in order to do it? // if so, let me know, I could self-taught some JavaScript during my leisure time.

show broken icon on items windows (main menu and battle).

Some windows not showing in a particular circumstance

Some specific windows are not showing in this circumstance. Shop example:

• Open the shop and choose Buy.
• Wait for the Buy menu appear.
• Press X followed by Z as fast as possible to return and back again to the Buy menu.
• Wait for the Buy menu appear.
• The description window won't show.

Something similar happens to Battle Menu:

But before migrating to the new menu/buttons system, it used to work:

Got to this old commit 996957d for reference.

Allow activating any kind of debug only after the game is created.

Some debug features can be activated before the game load is complete, then causing the game to crash.

Horizontal Menu squeezing

Shop horizontal menu is squeezing when doing the following:

• Open the shop and choose Buy.
• Wait for the Buy menu appear.
• Press X followed by Z as fast as possible to return and back again to the Buy menu.
• Wait for the Buy menu appear.
• Press X to return.

(Please note that the description window is also hiding, but it's another issue).

This behavior does not happen on the Main Menu and Battle Menu:

Allow the interactable objects "allowed_tiles" property (and similar properties) to accept polygons/ranges of tiles.

Today we set tile by tile inside "allowed_tiles" property. Would nice to be possible to set some kind of range to make this set easier.

Phaser 3!!!

Hello @jjppof ! I absolutely LOVE this! PLEASE keep up the GREAT work! <3

Second, PLEASE make it Phaser 3!

Some bugs i found.

When battling cant flee or watch stats also when i was in battle it soft locked. (Couldn't skip the text)
When going behind the shop the shadow goes in front of you.
Move soft locked the game. And the fps isn't stable.
I don't know if any of these helped but there you go!

Audio Engine.

Implement the game audio engine.

consume items when using at battle.

When using an item during battle (e.g. Herb), the item is not being consumed.

Wrong position adjust after moving

Hero is moving wrongly after moving a pillar.

Facing wrong direction on corners

I noticed something odd about walking into diagonal walls, and sometimes still going south even on vertical walls.

Build Status Menu.

Inn system

Implement the game Inn system.

Battle log is overlapping battle bg.

The log letters should be shown below the battle background.

Jitter

It seems to be a subpixel precision problem.

Current configs:

//index.js
game.antialias = false;
game.stage.smoothed = false;
game.camera.roundPx = true; //floor rounding

//initializers/hero_control.js
game.camera.follow(data.hero, Phaser.Camera.FOLLOW_LOCKON, numbers.CAMERA_LERP, numbers.CAMERA_LERP);

follow reference.
roundPx reference.

Jitter still happens when manually updating the camera:

//disabling follow and roundPx
const camera_pos_x = Math.floor(data.hero.body.x - (numbers.GAME_WIDTH >> 1));
const camera_pos_y = Math.floor(data.hero.body.y - (numbers.GAME_HEIGHT >> 1));
game.camera.setPosition(camera_pos_x, camera_pos_y);

Setting game.camera.roundPx and game.renderer.renderSession.roundPixels to false solves the jitter for the hero and map, but adds jitter to the NPCs.

* @method Phaser.Physics.P2.Body#postUpdate and * @method PIXI.WebGLSpriteBatch#render can be edited to set sprite position.

Finish Item menu.

Add walk/run animations for all characters

Used in shop and healer menus

Improve TS types definition.

Typescript migration was done with minimal resources to doesn't make the project crash. Many improvements can be done in order to have better typing like defining types for functions arguments and better protecting attributes ( use of private, protected and public), for instance.

Battle freezing

The battles worked fine for me the first few times I tried, and now it just freezes when it reaches Sheba's turn (she's the first to attack). It says she used whatever it is you tell her to do (I used Attack) but then the game just soft locks and doesn't go anywhere. The idle animations still play for everyone though.

Face direction different from move direction

Somehow... I can be facing down/left while moving downward but not leftward... kinda hard to do.
And you can face left move downward too. (If you use up and down arrows instead of left or right and down arrows.)
In general, whichever key you push first is the direction you go in, and the second key (of other three arrows) affects direction you face.

Move custom sprite data to Phaser.Sprite.data object

Many custom properties were added to Phaser.Sprite, but would be nice if they were placed inside Phaser.Sprite.data as far as possible. Some examples on phaser.d.ts:

Improve shop NPC interaction when talking from the back.

When talking to shop NPC from its back, it should start a dialog and not the shop.

Remove broken attr from Item class.

growth miss target animation not working in a map that does not have a sprout.

Pressing ESC in order to return in a menu is exiting the fullscreen mode when it's activated.

Move tile event value checks passed to events' constructors on Map.ts into TileEvent.ts constructor.

All the data checks done when creating TileEvents child classes (TeleportEvent, SpeedEvent ...) instances on Map.ts should be done inside theirs ctors.

Flip move hand once start moving