Comments (7)
Or if you can do the free port check internally so we know that:
{method: 'getendpoint'}
Will always work and return us an available port.
That would be ideal. But if that's too much work on your end we can do the check ourselves and pass it through.
from supernet.
good idea. if the port requested is inuse, you will get an error and have to use a different port.
I will add "port" field to getendpoint
from supernet.
pushed version with support for "port" field in getendpoint, it will use that to bind the endpoint.
only one such endpoint is supported, so the first getendpoint that succeeds will be the endpoint for that session. default is 5555
from supernet.
Sounds good, will test tomorrow.
from supernet.
This appears to have introduced a bug where mm always thinks the port is in use so I can no longer connect to the websocket:
$ curl 'http://127.0.0.1:49707/' --data-binary '{"queueid":0,"method":"getendpoint"}'
{"error":"Address already in use","err":-1,"socket":12}
$ curl 'http://127.0.0.1:49707/' --data-binary '{"queueid":0,"method":"getendpoint","port":5555}'
{"error":"Address already in use","err":-1,"socket":12}
$ curl 'http://127.0.0.1:49707/' --data-binary '{"queueid":0,"method":"getendpoint","port":1234}'
{"error":"Address already in use","err":-1,"socket":12}
Ports 5555 and 1234 are definitely free.
from supernet.
found bug, fixed
from supernet.
Resolved, thanks!
from supernet.
Related Issues (20)
- Emit `portfolio` event over WebSocket HOT 15
- Use error codes HOT 2
- Inconsistent aliceid between tradestatus and socket events HOT 6
- Use UUIDs for swaps HOT 38
- Latest mm builds crash when sending messages over the socket HOT 17
- Detect unmatched swaps HOT 21
- Swap failed, then a few seconds later completed HOT 10
- Are the on-disk swap db files required for marketmaker operation? HOT 4
- What does the `values` array for a swap represent HOT 8
- Swaps stuck as pending HOT 11
- Migrate Coinmarketcap API URL to Version 2
- Electrum balances not showing properly HOT 5
- What does the output of the cancel command mean. HOT 4
- `sendrawtransaction` doesn't return valid JSON HOT 4
- Marketmaker should not report `price` for test currencies HOT 10
- swapstatus causes marketmaker to crash HOT 3
- `aliceclaim` value not set in values array HOT 19
- GTC orders don't match properly HOT 8
- fail/cancel message is sent incorrectly for a swap that isn't cancelled HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from supernet.