Comments (4)
they are not needed after a swap reaches the finished state, ie. a .finished file is there
also please make sure to save all the data as it could be needed to recover funds in case something goes wrong.
so the files are needed temporarily, after that they can be transferred into the DB.
maybe when there are no pending swaps, it is something that can be done in a batch
from supernet.
please make sure to save all the data as it could be needed to recover funds in case something goes wrong.
Yep, every single swap database entry has it's HTTP request/response JSON saved along with every JSON message we receive over the socket.
so the files are needed temporarily, after that they can be transferred into the DB.
maybe when there are no pending swaps, it is something that can be done in a batch
Yeah, I was thinking about some kind of batching, maybe just on app quit would be enough.
So we definitely can't disable them all together? They are a small privacy leak. People could easily derive your address and balance from the TXIDs. Our swap DB is encrypted so none of the TXIDs we store are readable by anyone else on the system, or more importantly in the event of losing a backup drive.
from supernet.
certainly a possible privacy leak if you lose your computer/drive to somebody else, but if you dont, then no leak.
maybe you can ask artem to not have files in 2.0
from supernet.
Well it's a similar issue with storing private keys in plain text. Obviously that's security instead of privacy so the implications are much higher. But if your data never gets into anyone else's hands it's perfectly fine. But inevitably it will eventually, so best to protect against that.
I will raise it with Artem for v2
from supernet.
Related Issues (20)
- Specify WebSocket port HOT 7
- Emit `portfolio` event over WebSocket HOT 15
- Use error codes HOT 2
- Inconsistent aliceid between tradestatus and socket events HOT 6
- Use UUIDs for swaps HOT 38
- Latest mm builds crash when sending messages over the socket HOT 17
- Detect unmatched swaps HOT 21
- Swap failed, then a few seconds later completed HOT 10
- What does the `values` array for a swap represent HOT 8
- Swaps stuck as pending HOT 11
- Migrate Coinmarketcap API URL to Version 2
- Electrum balances not showing properly HOT 5
- What does the output of the cancel command mean. HOT 4
- `sendrawtransaction` doesn't return valid JSON HOT 4
- Marketmaker should not report `price` for test currencies HOT 10
- swapstatus causes marketmaker to crash HOT 3
- `aliceclaim` value not set in values array HOT 19
- GTC orders don't match properly HOT 8
- fail/cancel message is sent incorrectly for a swap that isn't cancelled HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from supernet.