[whishlist] Add desktop notifications

[jle64]

[whishlist] Add desktop notifications

[pmlopes]

I've got it working for me with this code:

def send_password_to_native_clipboard(self, name):
        pass_cmd = subprocess.run(['pass', 'show', '-c', name])

        if pass_cmd.returncode:
            self.notify('Failed to copy password!', error=True)
        else:
            self.notify('Password {} copied to clipboard.'.format(name))

By not creating pipes from the stdin/stdout it works, but I loose the context for error messages, not optimal but works for me...

[pmlopes]

if you use the hints:

{'transient': True}

then they do not stay in the history (hints is the argument before the timeout.

[jle64]

Whoah, I didn't realize there was any user of this beside me yet :)

Yeah, good points I'll look into adding some libnotify notifications with stderr output when pass exits != 0 and when a password is copied to clipboard.

[pmlopes]

I guess you can use DBus directly e.g.:

                
notifications_dbus = session_bus.get_object('org.freedesktop.Notifications', '/org/freedesktop/Notifications')
notify = dbus.Interface(notifications_dbus, 'org.freedesktop.Notifications')
notify.Notify (name, 0, '', ' password copied.', '', '', '', 3000)

I'm no dbus expert or python but this gives me some hints, it probably needs some polishing specially with the messages and defaults but again i just looked at the spec for 5 minutes....

[jle64]

I've added it. Notifications seems to stay indefinitely in Gnome notifications history despite setting a 3s timeout though. Also I barely tested :)

[pmlopes]

👍

[pmlopes]

Also for some strange reason on my Fedora 26 notifications have a huge delay before they show up. How do you debug this?

[jle64]

I changed notifications to be transient. I have no idea why you would have a delay when notifications show up, I don't have the problem.

[pmlopes]

it seems like a deadlock on the subprocess until some timeout happens

[matze]

Also for some strange reason on my Fedora 26 notifications have a huge delay before they show up.

And it's pretty annoying as well …

[matze]

Thanks, that works well. However, that means no GPaste support but I personally do not use that anyway.

[jle64]

@pmlopes : I imported your version of the function.

@matze : The problem doesn't occur with GPaste support anyway (which is why I didn't see it) as it seems to be due to the subprocess call blocking until the end of the 45 seconds before clearing the clipboard content, which isn't used in the case of GPaste.