jle64/gnome-pass-search-provider

Pass password manager search provider for gnome-shell

gnome-pass-search-provider's Issues

AttributeError: 'bool' object has no attribute 'lower'

I have this error that makes the service fail to start since a few days. Here's the journal output:

systemd[1174]: Starting Pass and Bitwarden search provider for GNOME Shell daemon...
systemd[1174]: Started Pass and Bitwarden search provider for GNOME Shell daemon.
gnome-pass-search-provider.py[11832]: Traceback (most recent call last):
gnome-pass-search-provider.py[11832]:   File "/usr/lib/gnome-pass-search-provider/gnome-pass-search-provider.py", line 248, in <module>
gnome-pass-search-provider.py[11832]:     SearchPassService()
gnome-pass-search-provider.py[11832]:   File "/usr/lib/gnome-pass-search-provider/gnome-pass-search-provider.py", line 71, in __init__
gnome-pass-search-provider.py[11832]:     getenv("DISABLE_NOTIFICATIONS", False).lower() == "true"
gnome-pass-search-provider.py[11832]: AttributeError: 'bool' object has no attribute 'lower'
systemd[1174]: org.gnome.Pass.SearchProvider.service: Main process exited, code=exited, status=1/FAILURE
systemd[1174]: org.gnome.Pass.SearchProvider.service: Failed with result 'exit-code'.

Fixed with #33

Writing an Ebuild for Gentoo

Hello,

i was attempting to write an Ebuild for Gentoo for this extension. I've closely followed the install.sh but i wasn't using it directly. So far, all the files are in their expected places.

Somehow i am still getting this error:

gnome-shell[1283]: Received error from DBus search provider org.gnome.Pass.SearchProvider.desktop: Gio.DBusError: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.gnome.Pass.SearchProvider was not provided by any .service files

The file itself is there:

-rw-r--r-- 1 root root 198 14. Dez 16:06 /usr/lib/systemd/user/org.gnome.Pass.SearchProvider.service

Is there anything i've missed?

Running Gnome Shell 3.32

Arch Linux: Unable to install due to permissions for /usr/lib/...

I was able to install this package on one of my two machines, but the second machine keeps failing during the installation. I'm using pikaur, but below I'll show you the manual build/install steps that result in the same issue.

$ pikaur -S gnome-pass-search-provider-git
Reading repository package databases...
Reading local package database...
Resolving AUR dependencies...

:: AUR package will be installed:
 gnome-pass-search-provider-git                             -> r9.bed2f59-2

:: Proceed with installation? [Y/n] 
:: [v]iew package details   [m]anually select packages
>> y
looking for conflicting AUR packages...
:: warning: Not showing diff for gnome-pass-search-provider-git package (installing for the first time)
Do you want to edit PKGBUILD for gnome-pass-search-provider-git package? [Y/n] n

:: Downloading the latest sources for a devel package gnome-pass-search-provider-git...

:: Starting the build:
==> Making package: gnome-pass-search-provider-git r49.79a0c36-1 (Fri 31 May 2019 07:44:38 PM EDT)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Updating gnome-pass-search-provider git repo...
Fetching origin
==> Validating source files with md5sums...
    gnome-pass-search-provider ... Skipped
==> Extracting sources...
  -> Creating working copy of gnome-pass-search-provider git repo...
Reset branch 'makepkg'
==> Starting pkgver()...
==> Removing existing $pkgdir/ directory...
==> Entering fakeroot environment...
==> Starting package()...
install: cannot create regular file '/usr/lib/gnome-pass-search-provider/gnome-pass-search-provider.py': Permission denied
==> ERROR: A failure occurred in package().
    Aborting...

Command 'makepkg --force' failed to execute.
:: Try recovering?
[R] retry build
[p] PGP check skip
[c] checksums skip
[i] ignore architecture
[d] delete build dir and try again
[e] edit PKGBUILD
------------------------
[s] skip building this package
[a] abort building all the packages

If I instead run sudo pikaur -S ..., I get a different error,

...
==> Entering fakeroot environment...
==> Starting package()...
install: cannot create regular file '/usr/lib/gnome-pass-search-provider/gnome-pass-search-provider.py': Read-only file system
==> ERROR: A failure occurred in package().
    Aborting...
Finished with result: exit-code
Main processes terminated with: code=exited/status=4
Service runtime: 894ms

Command 'systemd-run --pipe --wait -p DynamicUser=yes -p CacheDirectory=pikaur -E HOME=/tmp -p WorkingDirectory=/var/cache/pikaur/build/gnome-pass-search-provider-git makepkg --force' failed to execute.
...

Trying to manually install it,

git clone https://aur.archlinux.org/gnome-pass-search-provider-git.git
cd gnome-pass-...-git.git
makepkg --si

Smiliar issue as previous method.

---

I did end up getting it to work. I had to modify the PKGBUILD,

 package() {
         cd "$srcdir/$_pkgname"
-         ./install.sh
+        sudo ./install.sh
 }

I don't have any experience creating PKGBUILD files, so I don't know if using sudo here is the correct thing to do.

flatpak build

This seems to be interesting in a Flatpak package.

about debian

hi
can i install it on my debian stretch?

ragards

[Request] Case-insensitive search

I tried to understand how you code works and saw that you're using difflib.SequenceMatcher. I have no idea how the ratio() method works, but to find "ArchLinux/..." I have to type at least "archli". Notice I'm using lower-case. I can get the result faster if I type "Arc", but that's slightly less convenient.

Is there something we can do? Maybe lower (or higher?) the value you compare with ratio() (which is 0.5)?

Doesn't work with 3.34

I have installed gnome 3.34 and gnome-pass-search-provider doesn't seem to work anymore. Results are just not shown.

Failed to copy password on gnome40 without Gpaste

GPG called two times when gpaste is not installed

Thanks for this great extension!

One minor annoyance I noticed with it is that when gpaste is not installed the extension calls pass (and thus gpg) two times. This is fine for most users, but if you have a smartcard (such as a YubiKey) that requires a physical touch to decrypt each file it gets annoying pretty fast, as you have to touch the smartcard two times each password you decrypt.

Thankfully after taking a look at the source the workaround (just installing gpaste) was trivial, but maybe you could check whether gpaste is available over DBus before choosing which method to copy the password to use?

Do not ask for unlock password automatically?

Thank you for this! Works very well, I use this with rbw!

I have one issue:

If I just started the computer, I don't always need my passwords yet, I just want to open a program by searching for its name. Of course pinentry pops up requesting the master password as I start to search. The search is unusable until I unlock the db, the dialog will reopen after each new typed character, even if I close the prompt.

Is it possible to not show up this dialog automatically? Maybe if the db is locked it won't try to search for a password, unless I search for unlock or Pass beforehand?

[whishlist] Add desktop notifications

When a user selects a password and presses enter there is no feedback, maybe a notification saying that the password was copied would be interesting.

Same when pass errors out. For example the gpg key is missing, then no feedback is reported and nothing gets into the clipboard.

Environment variable loading

I'd like to set a environment variable in .bashrc.

export PASSWORD_STORE_DIR=$XDG_DATA_HOME/pass

Then this search provider doesn't work. Please fix it.

fuzzywuzzy was renamed to thefuzz

According to the fuzzywuzzy README.md, the project was renamed to thefuzz.

[Request] Package for Nix or publish on extensions.gnome.org

NixOS is an immutable Linux-based OS that uses its own paths incompatible with the FHS.

Are there blockers from publishing this directly on extensions.gnome.org?

Pass entries don't show up in search

This seem to be the relevant log lines:

Jan 25 14:54:17 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Activating service name='org.gnome.ControlCenter.SearchProvider' requested by ':1.42' (uid=1000 pid=2386 comm="/usr/bin/gnome-shell " label="unconfined")
Jan 25 14:54:17 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Activating service name='org.gnome.Contacts.SearchProvider' requested by ':1.42' (uid=1000 pid=2386 comm="/usr/bin/gnome-shell " label="unconfined")
Jan 25 14:54:17 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Activating service name='org.gnome.Nautilus' requested by ':1.42' (uid=1000 pid=2386 comm="/usr/bin/gnome-shell " label="unconfined")
Jan 25 14:54:17 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Activating service name='org.gnome.Calculator.SearchProvider' requested by ':1.42' (uid=1000 pid=2386 comm="/usr/bin/gnome-shell " label="unconfined")
Jan 25 14:54:17 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Activating service name='org.gnome.Calendar' requested by ':1.42' (uid=1000 pid=2386 comm="/usr/bin/gnome-shell " label="unconfined")
Jan 25 14:54:17 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Activating via systemd: service name='org.gnome.Pass.SearchProvider' unit='org.gnome.Pass.SearchProvider.service' requested by ':1.42' (uid=1000 pid=2386 comm="/usr/bin/gnome-shell " 
label="unconfined")
Jan 25 14:54:17 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Activating service name='org.gnome.seahorse.Application' requested by ':1.42' (uid=1000 pid=2386 comm="/usr/bin/gnome-shell " label="unconfined")
Jan 25 14:54:17 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Activating service name='org.gnome.Weather.BackgroundService' requested by ':1.42' (uid=1000 pid=2386 comm="/usr/bin/gnome-shell " label="unconfined")
Jan 25 14:54:17 critter systemd[1550]: Starting Pass search provider for GNOME Shell daemon...
Jan 25 14:54:17 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Successfully activated service 'org.gnome.ControlCenter.SearchProvider'
Jan 25 14:54:17 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Successfully activated service 'org.gnome.Pass.SearchProvider'
Jan 25 14:54:17 critter systemd[1550]: Started Pass search provider for GNOME Shell daemon.
Jan 25 14:54:17 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Successfully activated service 'org.gnome.seahorse.Application'
Jan 25 14:54:17 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Successfully activated service 'org.gnome.Weather.BackgroundService'
Jan 25 14:54:17 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Successfully activated service 'org.gnome.Contacts.SearchProvider'
Jan 25 14:54:18 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Successfully activated service 'org.gnome.Calculator.SearchProvider'
Jan 25 14:54:18 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Successfully activated service 'org.gnome.Nautilus'
Jan 25 14:54:18 critter dbus-daemon[1569]: [session uid=1000 pid=1569] Successfully activated service 'org.gnome.Calendar'

Jan 25 14:54:18 critter systemd[1550]: Started GnuPG cryptographic agent and passphrase cache.
Jan 25 14:54:18 critter gpg-agent[9696]: gpg-agent (GnuPG) 2.2.20 starting in supervised mode.
Jan 25 14:54:18 critter gpg-agent[9696]: using fd 3 for browser socket (/run/user/1000/gnupg/S.gpg-agent.browser)
Jan 25 14:54:18 critter gpg-agent[9696]: using fd 4 for std socket (/run/user/1000/gnupg/S.gpg-agent)
Jan 25 14:54:18 critter gpg-agent[9696]: using fd 5 for ssh socket (/run/user/1000/gnupg/S.gpg-agent.ssh)
Jan 25 14:54:18 critter gpg-agent[9696]: using fd 6 for extra socket (/run/user/1000/gnupg/S.gpg-agent.extra)
Jan 25 14:54:18 critter gpg-agent[9696]: listening on: std=4 extra=6 browser=3 ssh=5
Jan 25 14:54:18 critter gnome-shell[2386]: Received error from D-Bus search provider org.gnome.seahorse.Application.desktop during GetResultMetas: Gio.DBusError: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface “org.gnome.Shell.SearchProvider2” on object at path /org/gnome/seahorse/Application
Jan 25 14:54:18 critter gnome-shell[2386]: Wrong number of result metas returned by search provider org.gnome.seahorse.Application.desktop: expected 3 but got 0

Is there anything else I can do for further debugging?

Installed version:

gnome-pass-search-provider/groovy,groovy,now 0.0~20191115+da2db41-1 all [installed]

When gpg is updated, but old gpg-agent is still running, passwords are not copied

Instead, the first line of stderr is copied - gpg: WARNING: server 'gpg-agent' is older than us (2.2.34 < 2.2.35). This message is on stderr and the password on stdout, so that could be an easy way to fix this.