Watcher should only recompile changed files, and its dependents.

[jlmakes]

Watcher should only recompile changed files, and its dependents.

[jlmakes]

I appreciate the reproduction, but the current behavior is by design.

I agree it has room for improvement—but there are constraints when integrating with Karma, and the current file watcher is the first one that:

• Correctly recompiles dependencies
• Does not excessively re-run tests
• Does not throw errors and false negatives

The cost is performance. Pull requests are welcome, but I will do my best to improve it.

[jlmakes]

Figure 1:

Submodules: A, B
Modules: 1, 2, 3, 4
Tests: T1, T2

Karma’s default behavior ignores dependent modules… so if B changes, only B will be reprocessed… and everything downstream that depends on B will now be stale. This is what #3 is about, and what #11 improved in version 3.

So, the custom watcher should take more time, because it’s processing more files. Our goal is to ensure the updated file—and its dependents downstream—are processed again. Ideally, we'd recompile only the changed file, and its descendants… so if B changes, then 1, 3, T1, and T2 are recompiled.

Figure 2:

This is exactly what version 3 does, except that it unintentionally re-ran tests for each processed file (#17). That means in the example above, the tests would have ran 5 times after changing B. Aside from spamming your terminal, Karma would encounter errors and false negatives.

So v5.0 addresses #3 and #17 with a new watcher that simply reprocesses all files; there’s definitely room for improvement (potentially using a strategy similar to #11). I’ll take a look at making this improvement in future releases.

[Paulskit]

While I completely agree with your info graphics, I'm not sure what I see locally corresponds to what you're saying. Saving a single .spec.js file with no external dependencies (no imports, requires, etc) now triggers full rebuild of all files with rollup.

Running all tests is not an issue, you can always limit only desired set of tests using something like 'fdescribe'.

Edit: I have created a demo project for this:

https://github.com/Paulskit/rollup-karma-performance-bug

Steps to reproduce:

1. npm i
2. npm test
3. Save translate.js or translate.spec.js

As you can see, on every translate file change (which has no external dependencies) you see warnings in console about not used dependencies. Those are coming from the mock1 file specifically for this reason. It proves that despite the file doesn't have any external dependencies, the entire bundle’s recompilation is triggered.

[Paulskit]

Clear enough. Thank you.

[danielnaab]

For anyone encountering this, here's my solution: create a test manifest that explicitly imports every spec in your test suite, and put only that single entry-point in the Karma config.

Watch tasks are much faster, due to the single compilation.

Presumably this is something that could be automated as part of the preprocessor, but is easy enough to maintain as an additional module in the test suite itself.