Ignore files that have a `null` byte

[jlmakes]

Ignore files that have a `null` byte

[OverZealous]

To add to this issue, I'm also getting it with babelHelpers now, which is being injected as '\u0000babelHelpers'. I'm assuming that the trend is to use null bytes to identify dynamically generated files so watchers can know to exclude them.

@jlmakes Would you be interested in a PR as @brianmhunt suggested above, to simply ignore any file names with a null byte in them?

This happens to be holding back a major PR for our codebase. 😕

[OverZealous]

Worked great for me! Thanks a ton!

[jlmakes]

Interesting, thanks @brianmhunt

So let's see if I understand—null bytes are a security concern for karma-rollup-preprocessor, but the patch would also serve as a downstream fix for an emergent bug in rollup-plugin-commonjs?

[brianmhunt]

So let's see if I understand—null bytes are a security concern for karma-rollup-preprocessor, but the patch would also serve as a downstream fix for an emergent bug in rollup-plugin-commonjs?

Yes, that is my understanding.

[jlmakes]

If it's just the one-liner he suggested I don't mind implementing it and bumping to 5.1

Edit: Just cut a new release. Let me know if this bug still bites @OverZealous @brianmhunt

[OverZealous]

That would be awesome! It fixed my issue when I added it manually. I just did this:

Watch.prototype.start = function() {
	this.clean()
	this.buffer.forEach(m => {
		if (m.includes('\u0000')) { return } /// <-- here
		if (!this.watchList.has(m)) {

But it could just as easily be merged with existing if.