jmcdo29/nest-docker-template

Small template for using NestJS and Docker together

nest-docker-template's Issues

[Feature] Improve GitHub CI for Dockerfile

I think could be a great idea to have a GitHub CI to check Dockerfile build issues. Do you agree?

I never did specifically something like it before but I think it is totally possible:

1. Pull Oficial NestJS Repository (https://github.com/nestjs/nest)
2. Change directory to "nest/sample/01-cats-app"
3. Replace sample nestjs project Dockerfile (if exists)
4. Run unit tests

This can detect problems in libraries like Prisma and bcryptjs in some circumstances.

Possible problem: A bug in the NestJS sample repository can lead to a "wrong" failed to build. I don't think because is a relevant problem because:

1. This probability only will happen when NodeJS has a breaking change (e.g. change from NodeJS v16 -> v17)
2. You can use the sha256 commit hash to pull the GitHub repository at a specific point in the history but I think we can test this approach first and check if is necessary later.
3. You can only remove this CI later. No other change is necessary 😁
4. @jmcdo29 is a relevant contributor on the NestJS project and can help if something breaks out 😁

What do you think? Can I develop this integration (CI) and submit a PR? Is it a good idea?

Docker image with npm

Hi.

Could you please add a version of this Docker image that uses npm (instead of yarn)?

Thank you.
Greetings
Erol

[Question] Why do you use an Operation System for build and another for production?

Hey there!

https://github.com/jmcdo29/nest-docker-template/blob/1725ab37442c7f4703d2becc71293f6dbe955116/Dockerfile

Using an Operation system for build and another for production, not can lead to problems with some specific binaries that were compiled for a non-alpine image?