EngineDriver not compatible

[jmri]

EngineDriver not compatible

[n3ix]

I get the same error. with 2.18 from the Play Store. FYI the MCII runs Android version 4.1.1 which should be way after the minimum version for ED?

[mattharris]

I'll have to look at this at the weekend as do not have access to hardware at the moment.
However, a quick thought comes to mind - didn't we add support for accelerometer based feedback during this past development phase? Only I do not think that the MCII has such hardware installed. It could be the way we're specifying the hardware requirements tripping us up.

Looking at the relevant line in the manifest, https://github.com/JMRI/EngineDriver/blob/master/AndroidManifest.xml#L26 we do not explicitly say if it's mandated or not.

Looking at the Android docs, https://developer.android.com/guide/topics/manifest/uses-feature-element.html#required it implies that as we've not included a suitable android:required declaration, it defaults to true thereby meaning that any hardware without an accelerometer will be marked incompatible. That this didn't come up during testing is due to Google Play using the uses-feature declaration for compatibility but direct loading not doing so.

[flash62au]

oh.. Peter

…

On 9 April 2018 at 20:13, Matthew Harris ***@***.***> wrote: I'll have to look at this at the weekend as do not have access to hardware at the moment. However, a quick thought comes to mind - didn't we add support for accelerometer based feedback during this past development phase? Only I do not think that the MCII has such hardware installed. It could be the way we're specifying the hardware requirements tripping us up. Looking at the relevant line in the manifest, https://github.com/JMRI/ EngineDriver/blob/master/AndroidManifest.xml#L26 we do not explicitly say if it's mandated or not. Looking at the Android docs, https://developer.android.com/ guide/topics/manifest/uses-feature-element.html#required it implies that as we've not included a suitable android:required declaration, it defaults to true thereby meaning that any hardware without an accelerometer will be marked incompatible. That this didn't come up during testing is due to Google Play using the uses-feature declaration for compatibility but direct loading not doing so. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#213 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ab2OA9Dy8NrgsUtOitUd7Xwq-pMdFslcks5tmzREgaJpZM4TLl8S> .

[SonnysHansen]

I managed to install version 2.18 via the apk download, without any problems.
Sonny

[flash62au]

I have added a new Pull Request to with the declaration included. I have no way to test it though. Peter

…

On 9 April 2018 at 20:13, Matthew Harris ***@***.***> wrote: I'll have to look at this at the weekend as do not have access to hardware at the moment. However, a quick thought comes to mind - didn't we add support for accelerometer based feedback during this past development phase? Only I do not think that the MCII has such hardware installed. It could be the way we're specifying the hardware requirements tripping us up. Looking at the relevant line in the manifest, https://github.com/JMRI/ EngineDriver/blob/master/AndroidManifest.xml#L26 we do not explicitly say if it's mandated or not. Looking at the Android docs, https://developer.android.com/ guide/topics/manifest/uses-feature-element.html#required it implies that as we've not included a suitable android:required declaration, it defaults to true thereby meaning that any hardware without an accelerometer will be marked incompatible. That this didn't come up during testing is due to Google Play using the uses-feature declaration for compatibility but direct loading not doing so. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#213 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ab2OA9Dy8NrgsUtOitUd7Xwq-pMdFslcks5tmzREgaJpZM4TLl8S> .

[n3ix]

I added the change to the uses-feature line in my copy of AndroidManifest. It loaded fine on the device, but as Matt pointed out this change only impacts loading from Play. I will uninstall the test version and retest it from Play it once Steve uploads a new version.

[n3ix]

The 2.18.1 beta loaded successfully from the Playstore.

[mstevetodd]

@SonnysHansen if you'd like to verify the 2.18.1 beta version on your MCII, please visit this site
https://play.google.com/apps/testing/jmri.enginedriver
and sign up to receive Beta updates: