jnessier/flash

NOT MAINTAINED ANYMORE. Flash messages service for Slim 4 and similar PSR-15 compliant frameworks or apps.

flash's Issues

addMessage should add a message, not set the group to the message

Hi

This morning I've tried to use your library and I fear that I stumbled on a simple bug: Flash::addMessage() should add the message not set the key to the message...

The current code is

    /**
     * {@inheritDoc}
     */
    public function addMessage(string $key, $message): FlashInterface
    {
        if (!isset($this->next[$key])) {
            $this->next[$key] = [];
        }

        $this->next[$key] = $message;

        return $this;
    }

but adding the message should imo be:

        $this->next[$key][] = $message;

Since you did define the return type of getMessages() php gave me a nice error instead of simply returning the wrong data : - ).

I will keep on testing your library, but, for now, it seems to do its job!

Make the project compatible with php 8.0

I'm using FlashMessages with PHP 8.0.x and it works well.

Can you please update composer.json to accept versions of PHP that are newer than 7.4?

As an example by setting

"php": ">=7.3"

or

"php": "^7.3 ||^8.0"

(supposing that it has not been tested with 8.1...

addCurrentMessage() ?

I normally plan to add the Flash Message to next.

But, I currently have one use case for messages that need to be rendered in the current session. And I'd prefer not to use a second library just for that...

I'd like to suggest to add addCurrentMessage to Flash.php.

(Of course I could use getCurrent() and setCurrent() but that's a huge hack!)

I can make a pull request if you agree with the idea.