jnjcc/cl-qrencode

QR code 2005 encoder in Common Lisp

cl-qrencode's Issues

Alnum mode is broken?

Hello!
(cl-qrencode-test::encode-alnum "qwe") produces

Argument X is not a NUMBER: NIL
[Condition of type SIMPLE-TYPE-ERROR]

Backtrace:
  0: (SB-KERNEL:TWO-ARG-* NIL 45)
  1: (CL-QRENCODE::PAIR->DECIMAL (NIL NIL NIL) 2)
      Locals:
        NUM = 2
        VALUES = (NIL NIL NIL)
  2: (CL-QRENCODE::ALNUM->BSTREAM (113 119 101))
  3: (CL-QRENCODE::SEGMENT->BSTREAM (:ALNUM 113 119 101) 1)

What about "you serious about this?!"?

Trying to encode some ASCII string I get the error "you serious about this?!" in CL-QRENCODE::TERMINATOR.

Why do I get that error?

Metadata for Quicklisp

Please consider adding :description, :author and :license information to your ASDF system(s). This will greatly help Quicklisp users and make it easier for them to report bugs.

More information:

http://blog.quicklisp.org/2015/05/looking-for-more-metadata.html
https://www.quicklisp.org

Non-scannable codes

I'm encoding the following string "ca85ce19c091fdcffae37b9c9cb0207b2b2c82df867e8a489a3dbe43796aa7896130de17ec68af131d8a6ebfb7324f8e904fe9598614a1772be418e1d5660c0dqwevfd" with defaults.

Neither my phone nor this service: https://zxing.org/w/decode.jspx can recognize/detect this generated qr code.

I tested this string using an online service:

This code perfectly scans

I understand setting can differ but anyway.

Q about a possible bug

Hi!

evaluate-feature-2 came up in a profile run as a function to be optimized; and while looking at it it occurred to me that it might be buggy.

It contains

(when (or (= bcount 0) (= bcount 4))
  (incf penalty n2))

but bcount isn't reset to 0 afterwards; I guess this is missing here, right?

If so you don't need to bother with a fix - I'm about to change it, I just wanted to know what it should do exactly ;)

Thanks for your help!

Wrong encoding for URL / bytes.

(cl-qrencode:encode-png "herpderp")

results in a QR code that is being decoded to

herpl�rp

(with zbarimg, an Android phone app and e.g. https://zxing.org/w/decode.jspx).

With the same settings, e.g. using qrencode -8 -l M "herpderp" -o qrcode-correct.png the data is decoded correctly, giving the resulting raw bytes

40 86 86 57 27 06 46 57   27 00 ec 11 ec 11 ec 11

whereas the wrong sequence is

40 86 86 57 27 06 c8 57   27 00 ec 11 ec 11 ec 11

With a bit of tracing I now think this is after the bit stream generation, so possibly in the EC coding functions.

(N.b. this is using an AFAIK fixed version of the padding, c.f. #5.)