jnolis/ggirl

Make GGplots In Real Life

ggirl's Issues

Package shouldn't require packages for examples, but gracefully handle when you don't have them

Minor Issue - Quantity does not seem to be working

Hi @jnolis ,

Thank you for your excellent package. I tried to make a couple of prints from one of our Maps; however, when I went to the app site, there was only one plot ($30 instead of $60). I am not sure if this is a bug or something wrong with my code.

For your reference, I am attaching the code that I used below (not really a minimal example but not huge either):

if(require(remotes) == FALSE) install.packages("remotes")
if(require(pacman)==FALSE) install.packages("pacman")
if(require(ggirl) == FALSE) remotes::install_github("jnolis/ggirl")

pacman::p_load(tidyverse, magrittr, lubridate, albersusa, tigris) # loading the required packages


clusterCounties = readRDS(url("https://github.com/fmegahed/covid19/blob/master/Data/clusterCounties.rds?raw=true")) # myData
clusterCounties$fips = str_pad(clusterCounties$key_numeric, width = 5, side = 'left', pad = '0')
clusterCounties %<>% ungroup()


cty_sf = counties_sf("aeqd") %>% filter(!state %in% c('Alaska', 'Hawaii')) # map from albersusa package
cty_sf %<>% left_join(clusterCounties[, c('fips', 'cluster_group')], by = 'fips') # adding cluster_group to cty_sf


cty_sf %>% # ggplot for the map inspired by https://stackoverflow.com/a/60843261/10156153
  ggplot() +
  geom_sf(mapping = aes(fill = cluster_group), color = "black") +
  coord_sf(datum = NA) +   
  scale_fill_brewer(palette = 'Set2') +
  theme_bw(base_size = 24) + theme(legend.position="bottom", panel.border = element_blank()) +
  labs(caption = 'Based on Data from March 01, 2020 - January 02, 2021') -> p


delivery_address <- address(name = "My Name", address_line_1 = "My Address",
                            address_line_2 = "", city = "Oxford", state = "OH",
                            postal_code = "45056", country = "US")
contact_email = "[email protected]"

ggartprint(p, background = "#FEFDF7", size="11x14", orientation = "landscape", quantity = 2,
           contact_email = contact_email, address = delivery_address)

Sometimes postcards have lots of image artifacts

Somehow with the postcard provider then end up printing the postcards in ways that look really low res and with lots of compression artifacts. I don't think this has anything to do with me--it happens on the back too and I use the same back image for everything.

I am currently in contact with the provider to see what they say

Text annotation previews

Text annotations in ggplot resize depending on the graphics window size and I have to trial & error. Would be cool if there were a shiny app or other way to preview the printed output of the chart before uploading it to the ggirl server.

Sunset/sunrise plot should be flipped

I feel like naturally the sunrise would be on the top and sunset on the bottom, with time going (top to bottom) 12 am 6 am 12 pm 6 pm.

not able to download package

Error in get(genname, envir = envir) : object 'testthat_print' not found
Downloading GitHub repo jnolis/ggirl@master
Error: Failed to install 'ggirl' from GitHub:
  HTTP error 404.
  No commit found for the ref master

  Did you spell the repo owner (`Ijeamakaanyene`) and repo name (`contouR`) correctly?
  - If spelling is correct, check that you have the required permissions to access the repo.

looks like it's around the new remote dependency you added?

grid.draw method error?

Hey! love this! trying it out for the first time I got this:

> ggpostcard(plot,
+            contact_email, 
+            messages = message_1,
+            send_addresses = send_address_1)
Waiting 10 seconds for ggirl server to come online
Error in UseMethod("grid.draw") : 
  no applicable method for 'grid.draw' applied to an object of class "function"

Do you know if that's on my ggplot itself or some bug in your shiny app?

Confirmation email 5-10 biz days doesn't address international orders

allow for printing code + address from Postcrossing accounts

See postcrossing.com!

Regex doesn't work in message

if my message is:

"message_1 <- "Hi, \n Thanks for the message. \n Emily"

The \n doesn't appear in the preview, but it also doesn't put the following text on a new line.

Make warning that postcards will be smudged more obvious

The US Postal Service machines are not really made for postcards and apparently these super tough rubber belts that leave marks on postcards. I have wording on the preview page that there will be smudges but I should make it more obvious

Postcards won't ship internationally

For some reason they don't realize the postcards are non US and are being rejected for having invalid US states. I am working it out with the postcard provider currently.

Messages with `{}` in them break the glue commands when sending confirmation emails