joanisc/loyaltycardsopen

Linux App to save and view all your loyalty cards and any kind of card. Ready to use with a Linux Phone.

loyaltycardsopen's Issues

Some problems with installation

Thank you for creating this much needed app. However I have had a couple of problems installing and using it

Firstly I think that there should be an installation script. For example the Shell script could be installed in /usr/bin, the desktop file in /usr/share/applications, the icon file in /usr/share/pixmaps, the python scripts in /usr/share /loyaltyCardsOpen and finally the user files (database and config) in ~/.config/loyaltyCardsOpen.

Secondly I presume that the Entry of the loyalty card number will generate a bar code. I could not check this because the entry will not save without a photo of the front and the back of the card. If the bar code is available then the photos are not actually essential, and the entry should be saved without them.

fix setup.py

Hi, I'm trying to package loyaltyCardsOpen to alpine linux (for postmarketOS). When downloading the source from https://github.com/joanisc/loyaltyCardsOpen/archive/refs/tags/v0.1.6.tar.gz and running python3 setup.py build I get the following error

error: Multiple top-level packages discovered in a flat-layout: ['css', 'tmp'].

To avoid accidental inclusion of unwanted files or directories,
setuptools will not proceed with this build.

If you are trying to create a single distribution with multiple packages
on purpose, you should not rely on automatic discovery.
Instead, consider the following options:

1. set up custom discovery (`find` directive with `include` or `exclude`)
2. use a `src-layout`
3. explicitly set `py_modules` or `packages` with a list of names

To find more information, look for "package discovery" on setuptools docs.

Thank you for this project, I think it could be a useful app.

Some cosmetic issues

When loyaltyCards opens for the first time it shows a completely blank screen,

after the first click it shows a partial (obscured) list

the full list should be displayed

Incorrect barcode

The latest updates look very good. Thank you very much.
So I have added my Intermarche card, one of the cards with 19 digits. The output for the entry was:
:::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
Card Name: Intermarche barcodeEntry: 3250390100098299963
comeFromEditSave:0
We will do an INSERT instead of update because it is not an edit
No Back or front image entered
Accessed SearchTab:
searchParam:%%
67 Example Card
94 Intermarche
cardName:Intermarche
codebar:3250390100098299963
id0:94
codebarYey:3250390100098299963
Barcode correctly Saved
No image where given
No image where given
cardName:Example Card
codebar: 123456789101
id0:67
codebarYey:123456789101
Barcode correctly Saved
Stored blob data into: tmp/67.jpg

Stored blob data into: tmp/67_back.jpg

cardName:Intermarche
codebar:3250390100098299963
id0:94
codebarYey:3250390100098299963
Barcode correctly Saved
No image where given
No image where given
:::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

Unfortunately, although the card number is saved and displayed as 3250390100098299963 the barcode is incorrect and displayed as 3250390100096

I know you are not keen on using the barcode programme to create the barcodes but compare the difference between the two:
$ barcode -b 3250390100098299963 -S -o storecard.svg
$ barcode -b 3250390100096 -S -o barcode.svg

PS: The Example card is not shown until Entry Cards is selected for the first time

Edit:
Actually no cards are shown until Entry Cards is selected.

Just a few suggestions

Thank you for the update. All seems to work fine.

1. "Make install.sh executable chmod +x install.sh" after cloning the install/uninstall shell scripts are already executable. Perhaps "Make sure that the install.sh and uninstall.sh are executable. $ chmod +x [script] if necessary.
2. There is no test for pip-barcode. The programme simply fails to start. May be add a test for the dependencies and an error message if any are not found?
3. "Execute to install the app install.sh ... " Should be "Execute to install the app, ./install.sh, ..."
4. "python3 ~/.local/share/loyaltyCardsOpen/loyaltyCards.py" will not work since you need to cd to the directory first. Suggest replacing with "~/.local/share/loyaltyCardsOpen/loyaltyCards.sh"

Is it possible to make the barcode box bigger - near to the width of the vertical screen?

I notice that when I close the programme it does not exit but continues to run in background.

Now that barcodes are available (I could not test them yet), can you either remove the requirement for a front and back image, or, preferably, use a default card image as in the screenshot ?