jodaorg/joda-time-hibernate

Hibernate mapping for Joda-Time.

joda-time-hibernate's Issues

LocalDateTime conversion fails on DST transition

I have outlined the issue in this blog post:

http://mnmlst-dvlpr.blogspot.de/2013/11/joda-time-to-jdbc-in-three-hard-lessons.html

In short: Relying on the default time zone when converting from partial to instant is not safe.

Support Hibernate 5

How about this?

Upgrade to latest joda-time (2.7)

I'd like to use this project with the latest joda-time. Is there any plan to accept any such contribution?

PersistentDateTime must implement nullSafeSet

Class 'PersistentDateTime' must either be declared abstract or implement abstract method 'nullSafeSet(PreparedStatement, Object, int, SessionImplementator)' in 'UserType'

<hibernate.version>4.3.8.Final</hibernate.version>
<jodaTime.version>2.7</jodaTime.version>
<jodaTimeHibernate.version>1.4</jodaTimeHibernate.version>

Bad results with PersistentLocalDate for old dates

For dates older than 1891-10-02, PersistentLocalDate gives bad results (value in DB is different then what java reads, and on the other side also written value to DB is different then was stored in java).

Connected to JodaOrg/joda-time#264

Fixed code for PersistentLocalDate (fixing reading from DB and writing to DB):

public class ProperPersistentLocalDate extends PersistentLocalDate {

    private static final long serialVersionUID = -3868992177810711321L;

    @Override
    public Object nullSafeGet(ResultSet resultSet, String string) throws SQLException {
        Object timestamp = StandardBasicTypes.DATE.nullSafeGet(resultSet, string);
        if (timestamp == null) {
            return null;
        }

        //static methods contructions needed for loading proper date from DB
        if (timestamp instanceof Date) {
            return LocalDate.fromDateFields((Date) timestamp);
        } else if (timestamp instanceof Calendar) {
            return LocalDate.fromCalendarFields((Calendar) timestamp);
        }

        return new LocalDate(timestamp);
    }

    @Override
    public void nullSafeSet(PreparedStatement preparedStatement, Object value, int index) throws HibernateException, SQLException {
        if (value == null) {
            StandardBasicTypes.DATE.nullSafeSet(preparedStatement, null, index);
        } else {
            //localDate.toDate() fix for storing proper date in DB (see parent impl for change)
            StandardBasicTypes.DATE.nullSafeSet(preparedStatement, ((LocalDate) value).toDate(), index);
        }
    }
}