johannrosenberg/jetmagic

A framework for building responsive Android apps using Jetpack Compose

jetmagic's Issues

Memory leak of MainViewModel

LeakCanary reports that the static var mainViewModel: MainViewModel in the Application class is leaked after ViewModel.onCleared() is invoked.

NavDrawerViewModel leaked

LeakCanary reports that an instance of NavDrawerViewModel is leaked after ViewModel.onCleared() is invoked.

Application crashes on Android 10 (API 29) Samsung Galaxy Note 10

Hi, as I said I will give a try your solution 😄
I think I found some problem. I mean reflection.
Generally reflection is bad idea. Statistically object initialization is about 10 times slower then new operator.
But it looks like compose have some additional policy in terms of reflection call inside compose functions

This line is breaking application startup (100% case)
composableInstance.viewmodel = composableResource.viewmodelClass.newInstance() as ViewModel

createRootComposableInstance() throws "has no zero argument constructor error"

createRootComposableInstance() seems to ignore composableResource.onCreateViewmodel

Typos in readme-navigation.md

"instancece mplements" -> "instance implements"
"naman." -> "navman." (multiple instances)

Licensing

At the end of README.md I see that your software is licensed under GPL3 (I get that both the library and the demo app share the same license).

Though this is entirely up to you (and I myself sometimes use GPL3 in my code when I see fit), for a library this somewhat impairs its usability. There are varying opinions about whether linking to a GPL3 library "infects" the whole application (requiring all of its code to be licensed under GPL3).

If you find it useful, please consider licensing your code (or at least the library) under LGPL.

This is not an issue per se, as nothing is broken. This is more a way to contact the author.