john-smilga/react-advanced-2020

react-advanced-2020's Issues

high severity vulnerabilities - advanced-2020-master

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:

https://opencollective.com/core-js
https://www.patreon.com/zloirock

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

[email protected] postinstall /Users/m***/Desktop/reactApp/react-advanced-2020-master/node_modules/core-js
node -e "try{require('./postinstall')}catch(e){}"

[email protected] postinstall /Users/m***/Desktop/reactApp/react-advanced-2020-master/node_modules/core-js-pure
node -e "try{require('./postinstall')}catch(e){}"

added 1638 packages from 798 contributors and audited 1638 packages in 17.264s

67 packages are looking for funding
run npm fund for details

found 2 high severity vulnerabilities
run npm audit fix to fix them, or npm audit for details`

useFetch

useEffect has missing dependency when implementing useFetch. The final solution uses useCallback which is not yet explained at this point in the video.

Would also be good to explain why console.log(products) results to multiple logs.

19f34c9

npm install && npm start will not work

I cloned this git repository into a folder then ran npm install && npm start and got all kinds of errors and I am not sure why. Up until now in the react course everything was working just fine

/setup/2-multiple-input.js isn't matching the setup file used in the tutorial's video.

Deleting some lines gets the file to match whats is displayed on 6:50:32

Failed at the [email protected] start script.

0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node', '/usr/bin/npm', 'start' ]
2 info using [email protected]
3 info using [email protected]
4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle [email protected]prestart: [email protected]
6 info lifecycle [email protected]start: [email protected]
7 verbose lifecycle [email protected]start: unsafe-perm in lifecycle true
8 verbose lifecycle [email protected]start: PATH: /usr/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/webdev/react-advanced-2020/node_modules/.bin:/home/webdev/.JSlib/bin:/home/webdev/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/snap/bin
9 verbose lifecycle [email protected]start: CWD: /home/webdev/react-advanced-2020
10 silly lifecycle [email protected]start: Args: [ '-c', 'react-scripts start' ]
11 silly lifecycle [email protected]start: Returned: code: 1 signal: null
12 info lifecycle [email protected]start: Failed to exec start script
13 verbose stack Error: [email protected] start: react-scripts start
13 verbose stack Exit status 1
13 verbose stack at EventEmitter. (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:332:16)
13 verbose stack at EventEmitter.emit (events.js:314:20)
13 verbose stack at ChildProcess. (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack at ChildProcess.emit (events.js:314:20)
13 verbose stack at maybeClose (internal/child_process.js:1022:16)
13 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5)
14 verbose pkgid [email protected]
15 verbose cwd /home/webdev/react-advanced-2020/src
16 verbose Linux 4.19.0-11-amd64
17 verbose argv "/usr/bin/node" "/usr/bin/npm" "start"
18 verbose node v12.20.0
19 verbose npm v6.14.8
20 error code ELIFECYCLE
21 error errno 1
22 error [email protected] start: react-scripts start
22 error Exit status 1
23 error Failed at the [email protected] start script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

9-custom-hooks: `url` usuage in `useEffect` and usage of `useCallback`

Just a point of clarification... In this part of the video: https://youtu.be/4UZrsTqkcW4?t=30845 it is stated that the fetch would re-execute anytime the url changed. However, the url that is passed into the useFetch hook is a plain javascript variable that was not setup by useState. I believe that the only way that useEffect would be able to detect a change to the url parameter is if the url parameter itself was setup using useState from the caller function.

Also in the video there is no mention of the useCallback hook, yet in 9-custom-hooks/final/2-useFetch.js it is used.